YosysJson Object #367
Draft
YosysJson Object #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverythingElseWasAlreadyTaken
requested changes
Jun 10, 2025
|
|
||
|
|
||
| BitVector = list[int | Literal["0", "1", "x", "z"]] | ||
|
|
There was a problem hiding this comment.
Please provide some documentation for these classes and methods in this file.
| @@ -136,9 +138,6 @@ def parseFabricCSV(fileName: str) -> Fabric: | |||
| if i[0].startswith("Tile"): | |||
| if "GENERATE" in i: | |||
| # import here to avoid circular import | |||
| from FABulous.fabric_generator.fabric_automation import ( | |||
There was a problem hiding this comment.
Removing this import will break the custom tile generation. Please add it again.
There was a problem hiding this comment.
We should try to avoid that. We can resolve this later when I do the file splitting.
| @@ -1024,20 +1023,17 @@ def parseBelFile( | |||
| json_file = filename.with_suffix(".json") | |||
| runCmd = [ | |||
| "yosys", | |||
| "-qp" | |||
| f"read_verilog -sv {filename}; proc -noopt; write_json -compat-int {json_file}", | |||
| f"-qpread_verilog -sv {filename}; proc -noopt; write_json -compat-int {json_file}", | |||
There was a problem hiding this comment.
Please use the FAB_YOSYS_PATH, instead of calling yosys directly, and add the check_if_application_exists function.
We could also think of moving all these yosys calls to the yosys_obj.py and make it a general yosys handler.
There was a problem hiding this comment.
Sure, I can do the move for better encapsulation.
KelvinChung2000
force-pushed
the
yosys-obj
branch
from
0201849 to
a1b7338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typing to yosys json file to aid development