Skip to content

Add pyqtgraph dependency for robot-log-visualizer #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Conversation

traversaro
Copy link
Member

No description provided.

@traversaro
Copy link
Member Author

The CI failure seems unrelated:

2025-07-08T18:34:50.8721830Z /Users/runner/work/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/embObjLib/diagnosticInfoParsers.cpp:559:39: error: non-constant-expression cannot be narrowed from type 'eObus_t' to 'uint8_t' (aka 'unsigned char') in initializer list [-Wc++11-narrowing]
2025-07-08T18:34:50.9726850Z   559 |             eOlocation_t location = { static_cast<eObus_t>(bus), 0, address};
2025-07-08T18:34:51.0729820Z       |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
2025-07-08T18:34:51.1734290Z /Users/runner/work/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/embObjLib/diagnosticInfoParsers.cpp:559:39: note: insert an explicit cast to silence this issue
2025-07-08T18:34:51.2473210Z   559 |             eOlocation_t location = { static_cast<eObus_t>(bus), 0, address};
2025-07-08T18:34:51.3374950Z       |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
2025-07-08T18:34:51.3915830Z       |                                       static_cast<uint8_t>(    )

@traversaro
Copy link
Member Author

The CI failure seems unrelated:

2025-07-08T18:34:50.8721830Z /Users/runner/work/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/embObjLib/diagnosticInfoParsers.cpp:559:39: error: non-constant-expression cannot be narrowed from type 'eObus_t' to 'uint8_t' (aka 'unsigned char') in initializer list [-Wc++11-narrowing]
2025-07-08T18:34:50.9726850Z   559 |             eOlocation_t location = { static_cast<eObus_t>(bus), 0, address};
2025-07-08T18:34:51.0729820Z       |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
2025-07-08T18:34:51.1734290Z /Users/runner/work/robotology-superbuild/robotology-superbuild/src/ICUB/src/libraries/icubmod/embObjLib/diagnosticInfoParsers.cpp:559:39: note: insert an explicit cast to silence this issue
2025-07-08T18:34:51.2473210Z   559 |             eOlocation_t location = { static_cast<eObus_t>(bus), 0, address};
2025-07-08T18:34:51.3374950Z       |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
2025-07-08T18:34:51.3915830Z       |                                       static_cast<uint8_t>(    )

This will be fixed by robotology/icub-main#1032 .

@traversaro traversaro merged commit 0ceec6e into master Jul 8, 2025
19 of 31 checks passed
@traversaro traversaro deleted the fixlog94 branch July 8, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants