generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add support for link.column-gap token #2485 #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eslook
wants to merge
35
commits into
main
Choose a base branch
from
feat/2485-add-support-for-link-column-gap-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
6e72e4d
feat: add support for link.column-gap token in link
ec5e709
feat: add `slot="icon"` and `slot="label"` support to `utrecht-link` …
e28c6fe
docs: add icon before after stories in link css storybook
6035199
docs: add icon and label for react link component
d04312e
chore: correct packages for token changeset
6581e3a
feat: add class `utrecht-link-button__label` to match extended `utrec…
b8135e5
feat: add class `utrecht-link-button__label` to match extended `utrec…
15825a0
feat: add tests for link with icon and label support
328f5a5
feat: add icon and label for react button-link component
6b3675d
feat: add icon and label for react link-button component
af9fa0c
feat: add `slot="icon"` and `slot="label"` support to `utrecht-button…
7dcf9a1
feat: add `slot="icon"` and `slot="label"` support to `utrecht-link-b…
6db48d0
refactor: consistent rendering of elements in the button/link/button-…
2046a70
docs: add link gap changeset should be minor
6fd8dc6
docs: icon in link in css storybook
be27b1a
docs: icon in button in css storybook
3478ded
docs: icon in button-link in css storybook
871d589
docs: icon in link-button in css storybook
990b4b1
feat: create missing link-button in angular based on link and button …
d77b496
docs: improve button-link angular story based on existing link and bu…
5e741a5
docs: add changeset for link-button angular component
a09f5f0
docs: icon in link-button in react storybook
e6106a4
docs: icon in link in react storybook
f254308
docs: icon in button-link in react storybook
ba94d93
docs: icon in button in react storybook
a419d95
docs: icon in button in web component storybook
ab6532d
docs: icon in button-link in web component storybook
eaf6fa3
docs: icon in link in web component storybook
750f706
docs: icon in link-button in web component storybook
7e23df1
refactor: remove not functioning optional element based on slot
7367be2
refactor: remove not functioning optional element based on slot
a80d399
fix: run prettier --write
785d8e2
chore: fix typo
Robbert a8c148f
refactor: use `createElement` instead of `cloneElement`
Robbert 4611cb2
chore: update changeset from major to minor
Robbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@utrecht/component-library-css": minor | ||
"@utrecht/button-link-css": minor | ||
--- | ||
|
||
Add optional class `utrecht-button-link__label` to match extended optional class `utrecht-button__label` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Add an optional `label` and `icon` property to React `ButtonLink` component, to support better styling of icons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@utrecht/web-component-library-angular": minor | ||
"@utrecht/web-component-library-stencil": minor | ||
"@utrecht/web-component-library-vue": minor | ||
--- | ||
|
||
Add `slot="icon"` and `slot="label"` support to `utrecht-button-link` web component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@utrecht/component-library-css": minor | ||
"@utrecht/link-button-css": minor | ||
--- | ||
|
||
Add optional class `utrecht-link-button__label` to match extended optional class `utrecht-link__label` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
--- | ||
|
||
Add an optional `label` and `icon` property to React `LinkButton` component, to support better styling of icons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@utrecht/web-component-library-angular": minor | ||
"@utrecht/web-component-library-stencil": minor | ||
"@utrecht/web-component-library-vue": minor | ||
--- | ||
|
||
Add `slot="icon"` and `slot="label"` support to `utrecht-link-button` web component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@utrecht/design-tokens": minor | ||
"@utrecht/component-library-css": minor | ||
"@utrecht/link-css": minor | ||
"@utrecht/button-link-css": minor | ||
--- | ||
|
||
Add design token `utrecht.link.column-gap` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@utrecht/component-library-css": minor | ||
"@utrecht/link-css": minor | ||
--- | ||
|
||
Add an optional element class `utrecht-link__label` to support other inline styling without a gap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@utrecht/component-library-react": minor | ||
"@utrecht/link-react": minor | ||
--- | ||
|
||
Add an optional `label` and `icon` property to React `Link` component, to support better styling of icons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@utrecht/web-component-library-angular": minor | ||
"@utrecht/web-component-library-react": minor | ||
"@utrecht/web-component-library-stencil": minor | ||
"@utrecht/web-component-library-vue": minor | ||
--- | ||
|
||
Add `slot="icon"` and `slot="label"` support to `utrecht-link` web component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"@utrecht/component-library-angular": minor | ||
"@utrecht/web-component-library-angular": minor | ||
"@utrecht/web-component-library-react": minor | ||
"@utrecht/web-component-library-stencil": minor | ||
"@utrecht/web-component-library-vue": minor | ||
--- | ||
|
||
Align slot behavior across `button`, `link`, `button-link` and `link-button` in Angular components, React components and web components: the `__label` element is always rendered and wraps both the `label` slot and the default slot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@utrecht/component-library-angular": major | ||
--- | ||
|
||
Add `link-button` Angular component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,3 +48,7 @@ | |
@include utrecht-button-link--active; | ||
} | ||
} | ||
|
||
@mixin utrecht-button-link__label { | ||
@include utrecht-button__label; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,3 +57,7 @@ | |
@extend .utrecht-link-button--active; | ||
} | ||
} | ||
|
||
.utrecht-link-button__label { | ||
@include utrecht-link-button__label; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
<ng-content></ng-content> | ||
<ng-content select="[slot=icon]"></ng-content> | ||
|
||
<span class="utrecht-button-link__label"> | ||
<ng-content select="[slot=label]"></ng-content> | ||
<ng-content></ng-content> | ||
</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,7 @@ | ||
<ng-content select="[slot=icon]"></ng-content> | ||
|
||
<span class="utrecht-button__label" *ngIf="hasLabel"> | ||
<ng-content select="[slot=label]"></ng-content> | ||
</span> | ||
|
||
<ng-content></ng-content> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.