Skip to content

feat: add support for link.column-gap token #2485 #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6e72e4d
feat: add support for link.column-gap token in link
Apr 11, 2025
ec5e709
feat: add `slot="icon"` and `slot="label"` support to `utrecht-link` …
Apr 11, 2025
e28c6fe
docs: add icon before after stories in link css storybook
Apr 11, 2025
6035199
docs: add icon and label for react link component
Apr 11, 2025
d04312e
chore: correct packages for token changeset
Apr 15, 2025
6581e3a
feat: add class `utrecht-link-button__label` to match extended `utrec…
Apr 15, 2025
b8135e5
feat: add class `utrecht-link-button__label` to match extended `utrec…
Apr 15, 2025
15825a0
feat: add tests for link with icon and label support
Apr 15, 2025
328f5a5
feat: add icon and label for react button-link component
Apr 15, 2025
6b3675d
feat: add icon and label for react link-button component
Apr 15, 2025
af9fa0c
feat: add `slot="icon"` and `slot="label"` support to `utrecht-button…
Apr 15, 2025
7dcf9a1
feat: add `slot="icon"` and `slot="label"` support to `utrecht-link-b…
Apr 15, 2025
6db48d0
refactor: consistent rendering of elements in the button/link/button-…
Apr 17, 2025
2046a70
docs: add link gap changeset should be minor
Apr 24, 2025
6fd8dc6
docs: icon in link in css storybook
Apr 25, 2025
be27b1a
docs: icon in button in css storybook
Apr 25, 2025
3478ded
docs: icon in button-link in css storybook
Apr 25, 2025
871d589
docs: icon in link-button in css storybook
Apr 25, 2025
990b4b1
feat: create missing link-button in angular based on link and button …
Apr 25, 2025
d77b496
docs: improve button-link angular story based on existing link and bu…
Apr 25, 2025
5e741a5
docs: add changeset for link-button angular component
Apr 25, 2025
a09f5f0
docs: icon in link-button in react storybook
Apr 25, 2025
e6106a4
docs: icon in link in react storybook
Apr 25, 2025
f254308
docs: icon in button-link in react storybook
Apr 25, 2025
ba94d93
docs: icon in button in react storybook
Apr 25, 2025
a419d95
docs: icon in button in web component storybook
Apr 25, 2025
ab6532d
docs: icon in button-link in web component storybook
Apr 25, 2025
eaf6fa3
docs: icon in link in web component storybook
Apr 25, 2025
750f706
docs: icon in link-button in web component storybook
Apr 25, 2025
7e23df1
refactor: remove not functioning optional element based on slot
Jun 10, 2025
7367be2
refactor: remove not functioning optional element based on slot
Jun 10, 2025
a80d399
fix: run prettier --write
Jun 10, 2025
785d8e2
chore: fix typo
Robbert Jun 16, 2025
a8c148f
refactor: use `createElement` instead of `cloneElement`
Robbert Jun 16, 2025
4611cb2
chore: update changeset from major to minor
Robbert Jun 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use createElement instead of cloneElement
Robbert committed Jun 16, 2025
commit a8c148f85e837fb6f55160da34e9078fb6fe8c0f
4 changes: 2 additions & 2 deletions packages/storybook-web-component/src/Button.stories.tsx
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import tokensDefinition from '@utrecht/button-css/src/tokens.json';
import tokens from '@utrecht/design-tokens/dist/index.json';
import iconSet from '@utrecht/icon/dist/index.json';
import { UtrechtButton, UtrechtIconBestemmingsplan, UtrechtParagraph } from '@utrecht/web-component-library-react';
import React from 'react';
import React, { createElement } from 'react';
import { PropsWithChildren } from 'react';
import { designTokenStory } from './design-token-story';

@@ -62,7 +62,7 @@ const ButtonStory = ({
value={value || undefined}
{...restProps}
>
{IconElement && React.cloneElement(<IconElement />, { slot: 'icon' })}
{IconElement && createElement(IconElement, { slot: 'icon' })}
{label && <span slot="label">{label}</span>}
{children}
</UtrechtButton>
4 changes: 2 additions & 2 deletions packages/storybook-web-component/src/ButtonLink.stories.tsx
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import tokensDefinition from '@utrecht/button-link-css/src/tokens.json';
import tokens from '@utrecht/design-tokens/dist/index.json';
import iconSet from '@utrecht/icon/dist/index.json';
import { UtrechtButtonLink, UtrechtIconBestemmingsplan } from '@utrecht/web-component-library-react';
import React from 'react';
import React, { createElement } from 'react';
import { PropsWithChildren } from 'react';
import { designTokenStory } from './design-token-story';

@@ -44,7 +44,7 @@ const ButtonLinkStory = ({
placeholder={placeholder || undefined}
target={target || undefined}
>
{IconElement && React.cloneElement(<IconElement />, { slot: 'icon' })}
{IconElement && createElement(IconElement, { slot: 'icon' })}
{label && <span slot="label">{label}</span>}
{children}
</UtrechtButtonLink>
4 changes: 2 additions & 2 deletions packages/storybook-web-component/src/LinkButton.stories.tsx
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import iconSet from '@utrecht/icon/dist/index.json';
import readme from '@utrecht/link-css/README.md?raw';
import tokensDefinition from '@utrecht/link-css/src/tokens.json';
import { UtrechtIconBestemmingsplan, UtrechtLinkButton, UtrechtParagraph } from '@utrecht/web-component-library-react';
import React from 'react';
import React, { createElement } from 'react';
import { PropsWithChildren } from 'react';
import { designTokenStory } from './design-token-story';

@@ -66,7 +66,7 @@ const LinkButtonStory = ({
type={type || undefined}
value={value ? String(value) : undefined}
>
{IconElement && React.cloneElement(<IconElement />, { slot: 'icon' })}
{IconElement && createElement(IconElement, { slot: 'icon' })}
{label && <span slot="label">{label}</span>}
{children}
</UtrechtLinkButton>