Skip to content

feat: add support for link.column-gap token #2485 #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

feat: add support for link.column-gap token #2485 #2797

wants to merge 35 commits into from

Conversation

eslook
Copy link
Contributor

@eslook eslook commented Apr 11, 2025 •
edited
Loading

Applies #2485 following similar change in #2315

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 10:13am

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (70dc1bc) to head (4611cb2).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
+ Coverage   90.34%   90.57%   +0.23%     
==========================================
  Files         192      197       +5     
  Lines        1668     1730      +62     
  Branches      353      374      +21     
==========================================
+ Hits         1507     1567      +60     
- Misses        155      157       +2     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Charlotte Gieltjes added 9 commits April 15, 2025 13:43
Robbert
Robbert requested changes Apr 24, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@eslook eslook marked this pull request as ready for review June 10, 2025 14:12
@eslook
Copy link
Contributor Author

eslook commented Jun 10, 2025

Alle feedback verwerkt, en overige issues gesplitst, zoals aangekaart in #2485 (comment)

@eslook eslook linked an issue Jun 16, 2025 that may be closed by this pull request
feature request: add support for link.column-gap token #2485
Open
15 tasks
Robbert
Robbert requested changes Jun 16, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Robbert Robbert enabled auto-merge (rebase) June 16, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Robbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: add support for link.column-gap token
2 participants
@eslook @Robbert