[eas-cli] fix CapabilityModel creation and syncing

[vonovak]

Why

The current implementation of capabilities syncing can lead to provisioning profiles becoming invalid. This PR refactors the syncing process to avoid this issue by making the following improvements:

1. Preventing unnecessary creation of capability identifiers that already exist
2. Only updating bundle capabilities when necessary

closes #1069
closes #1445

How

I refactored the capability syncing logic to:

• Add test coverage for faulty behaviors. More tests are up the stack.
• Only create capability identifiers that don't already exist on the server
• Skip updating bundle capabilities when no changes are needed

Test Plan

easd command below is from https://github.com/expo/eas-cli/blob/main/CONTRIBUTING.md#development.

To best test this locally, have an iOS app with

(1) no capabilities enabled. Enable some capabilities in app.json and run prebuild. iCloud, Apple Sign In, app groups, or "com.apple.developer.default-data-protection": "NSFileProtectionComplete / ..." are of special interest, but any will do.

OR

(2) a buch of capabilities already enabled

using this app, run easd build -p ios TWO times. Confirm that the first build creates new capabilities on your app bundle (https://developer.apple.com/account/resources/identifiers/list) and provisioning profiles (if any). Confirm the second build passes and doesn't require any provisioning profile changes.

Finally, change the capabilities, and again run easd build -p ios twice to confirm no capabilities / provisioning profiles are changed on the second run (that's what should happen on the first run).

• green CI
• local tests

[vonovak]

• [eas-cli] fix CapabilityModel creation and syncing #3088 👈 (View in Graphite)
• [eas-cli] refactor capability syncing #3087
• [eas-cli] fix capability syncing #3086
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Size Change: -2.34 kB (0%)

Total Size: 53.5 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	53.5 MB	-2.34 kB (0%)

_{compressed-size-action}

[codecov]

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (a88897b) to head (90fa44c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../credentials/ios/appstore/capabilityIdentifiers.ts	80.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   51.77%   51.77%   +0.01%     
==========================================
  Files         607      607              
  Lines       24385    24385              
  Branches     5120     5119       -1     
==========================================
+ Hits        12622    12624       +2     
+ Misses      10713    10712       -1     
+ Partials     1050     1049       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@sjchmiela

Generated by CodeMention

[github-actions]

✅ Thank you for adding the changelog entry!

[vonovak]

Merge activity

• Jul 14, 8:34 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 14, 8:34 PM UTC: @vonovak merged this pull request with Graphite.