Skip to content

[eas-cli] refactor capability syncing #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Jul 3, 2025

Why

This PR refactors the iOS capability synchronization logic to make it more "linear" and easier to maintain

How

  • Encapsulating capability-specific logic with the capability definition
  • Making the operation decision process more explicit and easier to follow

Test Plan

  • green CI
  • local tests

Copy link
Contributor Author

vonovak commented Jul 3, 2025

Copy link

github-actions bot commented Jul 3, 2025

Size Change: -1.07 kB (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB -1.07 kB (0%)

compressed-size-action

@vonovak vonovak force-pushed the vonovak/_eas-cli_improve_capability_syncing branch from 2b5f70b to 886f645 Compare July 3, 2025 14:59
@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch 2 times, most recently from 5a320b6 to 9e67180 Compare July 3, 2025 15:00
@vonovak vonovak force-pushed the vonovak/_eas-cli_improve_capability_syncing branch from 886f645 to 8f83395 Compare July 3, 2025 15:00
@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch 2 times, most recently from 9dab486 to 73ecbb2 Compare July 3, 2025 17:45
@vonovak vonovak force-pushed the vonovak/_eas-cli_improve_capability_syncing branch from 7d8d903 to aeabf23 Compare July 3, 2025 17:45
@vonovak vonovak marked this pull request as ready for review July 4, 2025 08:13
Copy link

github-actions bot commented Jul 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @sjchmiela

Generated by CodeMention

@douglowder douglowder self-requested a review July 6, 2025 10:08
@douglowder douglowder added the no changelog PR that doesn't require a changelog entry label Jul 7, 2025 — with Graphite App
@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch from 73ecbb2 to a8be45c Compare July 14, 2025 17:04
@vonovak vonovak force-pushed the vonovak/_eas-cli_improve_capability_syncing branch from aeabf23 to c736c75 Compare July 14, 2025 17:04
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (8431167) to head (65de17f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cli/src/credentials/ios/appstore/capabilityList.ts 90.39% 5 Missing ⚠️
...c/credentials/ios/appstore/bundleIdCapabilities.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   51.77%   51.77%   -0.00%     
==========================================
  Files         607      607              
  Lines       24382    24385       +3     
  Branches     5123     5120       -3     
==========================================
+ Hits        12621    12622       +1     
- Misses      10711    10713       +2     
  Partials     1050     1050              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch from a8be45c to a92141d Compare July 14, 2025 19:42
@vonovak vonovak changed the base branch from vonovak/_eas-cli_improve_capability_syncing to graphite-base/3087 July 14, 2025 20:05
@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch from a92141d to 1588bfc Compare July 14, 2025 20:09
@vonovak vonovak force-pushed the graphite-base/3087 branch from 4aaaa78 to 8431167 Compare July 14, 2025 20:09
@graphite-app graphite-app bot changed the base branch from graphite-base/3087 to main July 14, 2025 20:10
@vonovak vonovak force-pushed the vonovak/_eas-cli_refactor_capability_syncing branch from 1588bfc to 65de17f Compare July 14, 2025 20:10
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link
Contributor Author

vonovak commented Jul 14, 2025

Merge activity

  • Jul 14, 8:29 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 14, 8:29 PM UTC: @vonovak merged this pull request with Graphite.

@vonovak vonovak merged commit a88897b into main Jul 14, 2025
12 checks passed
@vonovak vonovak deleted the vonovak/_eas-cli_refactor_capability_syncing branch July 14, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants