[eas-cli] fix capability syncing #3086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 3, 2025
|
Size Change: -3.19 kB (-0.01%) Total Size: 53.5 MB
|
vonovak
force-pushed
the
vonovak/_eas-cli_improve_capability_syncing
branch
4 times, most recently
from
7d8d903 to
aeabf23
Compare
vonovak
commented
Jul 3, 2025
| // - settings are not defined in the existing capability, but usesBroadcastPushNotifications is enabled (we want to add settings for this capability) | ||
| // - settings are defined in the existing capability, but usesBroadcastPushNotifications is disabled (we want to remove settings for this capability) | ||
| const noSettingsAttributes = existing.attributes.settings == null; | ||
| return !noSettingsAttributes === additionalOptions.usesBroadcastPushNotifications; | ||
| } | ||
|
|
||
| function shouldSkipIcloudCapabilityUpdate( |
There was a problem hiding this comment.
this is removed in the next PR up the stack so not worth spending much time here
|
Subscribed to pull request
Generated by CodeMention |
douglowder
added
the
no changelog
Graphite App
douglowder
approved these changes
Jul 7, 2025
vonovak
force-pushed
the
vonovak/_eas-cli_improve_capability_syncing
branch
from
aeabf23 to
c736c75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
==========================================
+ Coverage 51.68% 51.77% +0.09%
==========================================
Files 606 607 +1
Lines 24344 24382 +38
Branches 5105 5123 +18
==========================================
+ Hits 12580 12621 +41
+ Misses 10713 10711 -2
+ Partials 1051 1050 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vonovak
changed the title
vonovak
force-pushed
the
vonovak/_eas-cli_improve_capability_syncing
branch
from
4aaaa78 to
f16fa46
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR refactors the iOS bundle ID capabilities management to improve handling of capabilities with complex settings. The current implementation doesn't properly handle capabilities that have settings - Sign In with Apple, iCloud, and Data Protection.
How
capabilityList.ts) to improve code organizationtoHaveBeenCalledWithinstead oftoBeCalled)Test Plan