Skip to content

RTIO: fix CQE semaphore bypass when no CQE item was created #93544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

RTIO: fix CQE semaphore bypass when no CQE item was created #93544

merged 1 commit into from
Jul 25, 2025

Conversation

ubieda
Copy link
Member

@ubieda ubieda commented Jul 23, 2025 •
edited
Loading

Otherwise, calls to rtio_cqe_consume_block will bypass the semaphore and held back in a Z_SPIN_DELAY(1) indefinitely.

Reference:

zephyr/include/zephyr/rtio/rtio.h

Lines 1154 to 1161 in ddc43f0

#ifdef CONFIG_RTIO_CONSUME_SEM
k_sem_take(r->consume_sem, K_FOREVER);
#endif
node = mpsc_pop(&r->cq);
while (node == NULL) {
Z_SPIN_DELAY(1);
node = mpsc_pop(&r->cq);
}

@ubieda
rtio: fix CQE semaphore by not giving it no CQE item was created
bd1c3c1 
Otherwise, calls to rtio_cqe_consume_block will bypass the semaphore
and held back in a Z_SPIN_DELAY(1) indefinitely.

Signed-off-by: Luis Ubieda <[email protected]>
@ubieda ubieda mentioned this pull request Jul 23, 2025
Draft
@ubieda ubieda added the bug The issue is a bug, or the PR is fixing a bug label Jul 23, 2025
@ubieda ubieda changed the title rtio: fix CQE semaphore by not giving it no CQE item was created RTIO: fix CQE semaphore bypass when no CQE item was created Jul 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ubieda ubieda marked this pull request as ready for review July 23, 2025 01:23
@zephyrbot zephyrbot requested review from teburd and yperess July 23, 2025 01:24
@ubieda ubieda requested a review from bjarki-andreasen July 23, 2025 06:33
@cfriedt cfriedt merged commit 1187e17 into zephyrproject-rtos:main Jul 25, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teburd teburd teburd approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@yperess yperess Awaiting requested review from yperess

Assignees

@teburd teburd

Labels
area: RTIO bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ubieda @teburd @bjarki-andreasen @cfriedt @zephyrbot