rtio: fix CQE semaphore by not giving it no CQE item was created

ubieda · cfriedt · commit 1187e172b2ed · 2025-07-25T08:06:08.000-04:00
Otherwise, calls to rtio_cqe_consume_block will bypass the semaphore
and held back in a Z_SPIN_DELAY(1) indefinitely.

Signed-off-by: Luis Ubieda &lt;luisf@croxel.com&gt;
diff --git a/include/zephyr/rtio/rtio.h b/include/zephyr/rtio/rtio.h
@@ -1309,6 +1309,9 @@ static inline void rtio_cqe_submit(struct rtio *r, int result, void *userdata, u
 		cqe->userdata = userdata;
 		cqe->flags = flags;
 		rtio_cqe_produce(r, cqe);
+#ifdef CONFIG_RTIO_CONSUME_SEM
+		k_sem_give(r->consume_sem);
+#endif
 	}
 
 	/* atomic_t isn't guaranteed to wrap correctly as it could be signed, so
@@ -1329,9 +1332,6 @@ static inline void rtio_cqe_submit(struct rtio *r, int result, void *userdata, u
 		}
 	}
 #endif
-#ifdef CONFIG_RTIO_CONSUME_SEM
-	k_sem_give(r->consume_sem);
-#endif
 }
 
 #define __RTIO_MEMPOOL_GET_NUM_BLKS(num_bytes, blk_size) (((num_bytes) + (blk_size)-1) / (blk_size))

Original file line number	Diff line number	Diff line change
`@@ -1309,6 +1309,9 @@ static inline void rtio_cqe_submit(struct rtio r, int result, void userdata, u`
`1309`	`1309`	`cqe->userdata = userdata;`
`1310`	`1310`	`cqe->flags = flags;`
`1311`	`1311`	`rtio_cqe_produce(r, cqe);`
	`1312`	`+#ifdef CONFIG_RTIO_CONSUME_SEM`
	`1313`	`+ k_sem_give(r->consume_sem);`
	`1314`	`+#endif`
`1312`	`1315`	`}`
`1313`	`1316`
`1314`	`1317`	`/* atomic_t isn't guaranteed to wrap correctly as it could be signed, so`
`@@ -1329,9 +1332,6 @@ static inline void rtio_cqe_submit(struct rtio r, int result, void userdata, u`
`1329`	`1332`	`}`
`1330`	`1333`	`}`
`1331`	`1334`	`#endif`
`1332`		`-#ifdef CONFIG_RTIO_CONSUME_SEM`
`1333`		`- k_sem_give(r->consume_sem);`
`1334`		`-#endif`
`1335`	`1335`	`}`
`1336`	`1336`
`1337`	`1337`	`#define __RTIO_MEMPOOL_GET_NUM_BLKS(num_bytes, blk_size) (((num_bytes) + (blk_size)-1) / (blk_size))`