Group all toggles in one component #4161
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| <template> | ||
| <div class="flex flex-col gap-4"> | ||
| <input-tooltip | ||
| v-if="showGPU" | ||
| inline | ||
| tooltip=" | ||
| Selecting a Node with GPU. | ||
| When selecting a node with GPU resources, please make sure that you have a rented node. To rent a node and gain access to GPU capabilities, you can use our dashboard. | ||
| " | ||
| > | ||
| <v-switch | ||
| color="primary" | ||
| inset | ||
| label="GPU" | ||
| :model-value="hasGPUModel" | ||
| @update:model-value="onUpdateHasGPU" | ||
| hide-details | ||
| /> | ||
| </input-tooltip> | ||
|
|
||
| <v-switch | ||
| color="primary" | ||
| inset | ||
| label="Rented By Me" | ||
| :model-value="rentedByMeModel" | ||
| @update:model-value="onUpdateRentedByMe" | ||
| hide-details | ||
| /> | ||
|
|
||
| <input-tooltip inline tooltip="Click to know more about dedicated machines." :href="manual?.dedicated_machines"> | ||
| <v-switch | ||
| color="primary" | ||
| inset | ||
| label="Rentable" | ||
| :model-value="dedicatedModel" | ||
| @update:model-value="onUpdateDedicated" | ||
| hide-details | ||
| /> | ||
| </input-tooltip> | ||
|
|
||
| <input-tooltip inline tooltip="Renting capacity on certified nodes is charged 25% extra."> | ||
| <v-switch | ||
| color="primary" | ||
| inset | ||
| label="Certified" | ||
| :model-value="certifiedModel" | ||
| @update:model-value="onUpdateCertified" | ||
| hide-details | ||
| /> | ||
| </input-tooltip> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { computed } from "vue"; | ||
|
|
||
| import { manual } from "@/utils/manual"; | ||
|
|
||
| const props = defineProps({ | ||
| rentedByMe: Boolean, | ||
| dedicated: Boolean, | ||
| certified: Boolean, | ||
| hasGPU: Boolean, | ||
| showGPU: { type: Boolean, default: false }, | ||
| }); | ||
|
|
||
| const emit = defineEmits(["update:rentedByMe", "update:dedicated", "update:certified", "update:hasGPU"]); | ||
|
|
||
| const rentedByMeModel = computed({ | ||
| get: () => !!props.rentedByMe, | ||
| set: val => emit("update:rentedByMe", val), | ||
| }); | ||
|
|
||
| const dedicatedModel = computed({ | ||
| get: () => !!props.dedicated, | ||
| set: val => emit("update:dedicated", val), | ||
| }); | ||
0oM4R marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const certifiedModel = computed({ | ||
| get: () => !!props.certified, | ||
| set: val => emit("update:certified", val), | ||
| }); | ||
|
|
||
| const hasGPUModel = computed({ | ||
| get: () => !!props.hasGPU, | ||
| set: val => emit("update:hasGPU", val), | ||
| }); | ||
|
|
||
| function onUpdateRentedByMe(val: boolean | null) { | ||
| rentedByMeModel.value = !!val; | ||
| } | ||
|
|
||
| function onUpdateDedicated(val: boolean | null) { | ||
| dedicatedModel.value = !!val; | ||
| } | ||
|
|
||
| function onUpdateCertified(val: boolean | null) { | ||
| certifiedModel.value = !!val; | ||
| } | ||
|
|
||
| function onUpdateHasGPU(val: boolean | null) { | ||
| hasGPUModel.value = !!val; | ||
| } | ||
|
There was a problem hiding this comment. i think inline change the values in template would be better, Those founciton are not used anywhere else There was a problem hiding this comment. I did, but it caused type-check errors, let me try adding types there There was a problem hiding this comment. @0oM4R I tried it, but it caused the same error I mentioned, so I returned to the previous solution. There was a problem hiding this comment. <v-switch
color="primary"
inset
label="Rented By Me"
:model-value="rentedByMeModel"
hide-details
@update:model-value="(val) => rentedByMeModel = !!val"
/>this works fine with me without any errors There was a problem hiding this comment. @samaradel please check this comment |
||
| </script> | ||
|
|
||
| <script lang="ts"> | ||
| export default { | ||
| name: "RentalFilterSwitches", | ||
| }; | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just remove this v-if condition and remove showGPU prop since it will always be true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, it's just check for only 2 solutions not the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please refer to replies above