Group all toggles in one component #4161
Conversation
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
- Fix manual import in caprover
| function onUpdateRentedByMe(val: boolean | null) { | ||
| rentedByMeModel.value = !!val; | ||
| } | ||
| function onUpdateDedicated(val: boolean | null) { | ||
| dedicatedModel.value = !!val; | ||
| } | ||
| function onUpdateCertified(val: boolean | null) { | ||
| certifiedModel.value = !!val; | ||
| } | ||
| function onUpdateHasGPU(val: boolean | null) { | ||
| hasGPUModel.value = !!val; | ||
| } |
There was a problem hiding this comment.
i think inline change the values in template would be better, Those founciton are not used anywhere else
example :
:model-value="(val)=> gpuModule = val"
There was a problem hiding this comment.
I did, but it caused type-check errors, let me try adding types there
There was a problem hiding this comment.
@0oM4R I tried it, but it caused the same error I mentioned, so I returned to the previous solution.
There was a problem hiding this comment.
<v-switch
color="primary"
inset
label="Rented By Me"
:model-value="rentedByMeModel"
hide-details
@update:model-value="(val) => rentedByMeModel = !!val"
/>this works fine with me without any errors
There was a problem hiding this comment.
@samaradel please check this comment
|
after toggle some of mentioned toggles, it is stuck in loading, and the pages in the response look weird! |
packages/playground/src/components/node_selector/TfSelectionDetails.vue
Outdated
Show resolved
Hide resolved
| function onUpdateRentedByMe(val: boolean | null) { | ||
| rentedByMeModel.value = !!val; | ||
| } | ||
| function onUpdateDedicated(val: boolean | null) { | ||
| dedicatedModel.value = !!val; | ||
| } | ||
| function onUpdateCertified(val: boolean | null) { | ||
| certifiedModel.value = !!val; | ||
| } | ||
| function onUpdateHasGPU(val: boolean | null) { | ||
| hasGPUModel.value = !!val; | ||
| } |
There was a problem hiding this comment.
@samaradel please check this comment
|
@0oM4R already did, I merged the development branch and ran |
There was a problem hiding this comment.
@samaradel
you can restore the unrelated changes by
git checkout origin/development <pathToTheFile>
This will get the version that is on the development branch
also please make sure to check the other comments
|
@0oM4R I did, and it's something in linting rules, as it keeps changing when I commit |
|
so this is due to the pre-commit script, as it sees the unrelated files you just reverted as changed files then apply liniting on it feel free to reach me out if any help needed |
Description
Group all toggles in one component
Changes
Group all toggles in one component across all solutions
Related Issues
Tested Scenarios
RentedByMe,Dedicated, andCertifiedif they do their job correctlyDocumentation PR
For UI changes, Please provide the Documentation PR on info_grid
To consider
Preliminary Checks:
UI Checks:
Code Quality Checks:
Testing Checklist
General Checklist