Skip to content

chore: Add trailing commas to all record types #8820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/ads/interstitial_ad_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,7 @@ shaka.ads.InterstitialAdManager = class {
/**
* @typedef {{
* ASSETS: !Array<shaka.ads.InterstitialAdManager.Asset>,
* SKIP-CONTROL: ?shaka.ads.InterstitialAdManager.SkipControl
* SKIP-CONTROL: ?shaka.ads.InterstitialAdManager.SkipControl,
* }}
*
* @property {!Array<shaka.ads.InterstitialAdManager.Asset>} ASSETS
Expand All @@ -1830,7 +1830,7 @@ shaka.ads.InterstitialAdManager.AssetsList;

/**
* @typedef {{
* URI: string
* URI: string,
* }}
*
* @property {string} URI
Expand All @@ -1841,7 +1841,7 @@ shaka.ads.InterstitialAdManager.Asset;
/**
* @typedef {{
* ENABLE-SKIP-AFTER: number,
* ENABLE-SKIP-FOR: number
* ENABLE-SKIP-FOR: number,
* }}
*
* @property {number} ENABLE-SKIP-AFTER
Expand Down
4 changes: 2 additions & 2 deletions lib/cast/cast_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ shaka.cast.CastUtils = class {
* @return {{
* length: number,
* start: function(number): number,
* end: function(number): number
* end: function(number): number,
* }}
* @private
*/
Expand Down Expand Up @@ -443,7 +443,7 @@ shaka.cast.CastUtils.PlayerPromiseMethods = [
* startTime: ?number,
* addThumbnailsTrackCalls: !Array<?>,
* addTextTrackAsyncCalls: !Array<?>,
* addChaptersTrackCalls: !Array<?>
* addChaptersTrackCalls: !Array<?>,
* }}
* @property {Object} video
* Dictionary of video properties to be set.
Expand Down
4 changes: 2 additions & 2 deletions lib/cea/cea608_data_channel.js
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ shaka.cea.Cea608DataChannel.TEXT_COLORS = [
* textColor: ?string,
* backgroundColor: ?string,
* italics: ?boolean,
* underline: ?boolean
* underline: ?boolean,
* }}
*/
shaka.cea.Cea608DataChannel.Style;
Expand All @@ -798,7 +798,7 @@ shaka.cea.Cea608DataChannel.Style;
* type: number,
* ccData1: number,
* ccData2: number,
* order: number
* order: number,
* }}
*
* @property {number} pts
Expand Down
2 changes: 1 addition & 1 deletion lib/cea/cea708_service.js
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ shaka.cea.Cea708Service.Colors = [
* pts: number,
* type: number,
* value: number,
* order: number
* order: number,
* }}
*
* @property {number} pts
Expand Down
2 changes: 1 addition & 1 deletion lib/cea/mp4_cea_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ shaka.cea.Mp4CeaParser.CodecBitstreamMap_ = new Map()
* defaultSampleDuration: number,
* defaultSampleSize: number,
* parsedTRUNs: !Array<shaka.util.ParsedTRUNBox>,
* timescale: number
* timescale: number,
* }}
*
* @property {?number} baseMediaDecodeTime
Expand Down
6 changes: 3 additions & 3 deletions lib/dash/content_protection.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ shaka.dash.ContentProtection = class {
* defaultInit: Array<shaka.extern.InitDataOverride>,
* drmInfos: !Array<shaka.extern.DrmInfo>,
* aes128Info: ?shaka.dash.ContentProtection.Aes128Info,
* firstRepresentation: boolean
* firstRepresentation: boolean,
* }}
*
* @description
Expand Down Expand Up @@ -645,7 +645,7 @@ shaka.dash.ContentProtection.Context;
/**
* @typedef {{
* keyUri: string,
* iv: !Uint8Array
* iv: !Uint8Array,
* }}
*
* @description
Expand All @@ -665,7 +665,7 @@ shaka.dash.ContentProtection.Aes128Info;
* schemeUri: string,
* keyId: ?string,
* init: Array<shaka.extern.InitDataOverride>,
* encryptionScheme: ?string
* encryptionScheme: ?string,
* }}
*
* @description
Expand Down
14 changes: 7 additions & 7 deletions lib/dash/dash_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1334,7 +1334,7 @@ shaka.dash.DashParser = class {
* @return {{
* periods: !Array<shaka.extern.Period>,
* duration: ?number,
* durationDerivedFromPeriods: boolean
* durationDerivedFromPeriods: boolean,
* }}
* @private
*/
Expand Down Expand Up @@ -3389,7 +3389,7 @@ shaka.dash.DashParser = class {
* profiles: !Array<string>,
* availabilityTimeOffset: number,
* getBaseUris: ?function():!Array<string>,
* publishTime: number
* publishTime: number,
* }}
*
* @property {string} mpdId
Expand Down Expand Up @@ -3460,7 +3460,7 @@ shaka.dash.DashParser.RequestSegmentCallback;
* aesKey: (shaka.extern.aesKey|undefined),
* segmentSequenceCadence: number,
* label: ?string,
* encrypted: boolean
* encrypted: boolean,
* }}
*
* @description
Expand Down Expand Up @@ -3536,7 +3536,7 @@ shaka.dash.DashParser.InheritanceFrame;
* mediaPresentationDuration: ?number,
* profiles: !Array<string>,
* roles: ?Array<string>,
* urlParams: function():string
* urlParams: function():string,
* }}
*
* @description
Expand Down Expand Up @@ -3578,7 +3578,7 @@ shaka.dash.DashParser.Context;
* start: number,
* duration: ?number,
* node: ?shaka.extern.xml.Node,
* isLastPeriod: boolean
* isLastPeriod: boolean,
* }}
*
* @description
Expand Down Expand Up @@ -3607,7 +3607,7 @@ shaka.dash.DashParser.PeriodInfo;
* drmInfos: !Array<shaka.extern.DrmInfo>,
* trickModeFor: ?string,
* representationIds: !Array<string>,
* dependencyStreamMap: !Map<string, shaka.extern.Stream>
* dependencyStreamMap: !Map<string, shaka.extern.Stream>,
* }}
*
* @description
Expand Down Expand Up @@ -3650,7 +3650,7 @@ shaka.dash.DashParser.GenerateSegmentIndexFunction;
* timeline: number,
* endTime: number,
* generateSegmentIndex: shaka.dash.DashParser.GenerateSegmentIndexFunction,
* timescale: number
* timescale: number,
* }}
*
* @description
Expand Down
2 changes: 1 addition & 1 deletion lib/dash/mpd_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ shaka.dash.MpdUtils = class {
* startNumber: number,
* scaledPresentationTimeOffset: number,
* unscaledPresentationTimeOffset: number,
* timeline: Array<shaka.media.PresentationTimeline.TimeRange>
* timeline: Array<shaka.media.PresentationTimeline.TimeRange>,
* }}
*
* @description
Expand Down
4 changes: 2 additions & 2 deletions lib/dash/segment_list.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ shaka.dash.SegmentList = class {
* @typedef {{
* mediaUri: string,
* start: number,
* end: ?number
* end: ?number,
* }}
*
* @property {string} mediaUri
Expand All @@ -353,7 +353,7 @@ shaka.dash.SegmentList.MediaSegment;
* scaledPresentationTimeOffset: number,
* timescale: number,
* timeline: Array<shaka.media.PresentationTimeline.TimeRange>,
* mediaSegments: !Array<shaka.dash.SegmentList.MediaSegment>
* mediaSegments: !Array<shaka.dash.SegmentList.MediaSegment>,
* }}
* @private
*
Expand Down
2 changes: 1 addition & 1 deletion lib/dash/segment_template.js
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,7 @@ shaka.dash.TimelineSegmentIndex = class extends shaka.media.SegmentIndex {
* mimeType: string,
* codecs: string,
* bandwidth: number,
* numChunks: number
* numChunks: number,
* }}
*
* @description
Expand Down
2 changes: 1 addition & 1 deletion lib/device/webos.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ shaka.device.WebOS = class extends shaka.device.AbstractDevice {

/**
* @typedef {{
* configs: Object
* configs: Object,
* }}
*
* @property {Object} configs
Expand Down
6 changes: 3 additions & 3 deletions lib/drm/drm_engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -2764,7 +2764,7 @@ shaka.drm.DrmEngine = class {
* initDataType: ?string,
* oldExpiration: number,
* type: string,
* updatePromise: shaka.util.PublicPromise
* updatePromise: shaka.util.PublicPromise,
* }}
*
* @description A record to track sessions and suppress duplicate init data.
Expand Down Expand Up @@ -2794,7 +2794,7 @@ shaka.drm.DrmEngine.SessionMetaData;
* onError: function(!shaka.util.Error),
* onKeyStatus: function(!Object<string,string>),
* onExpirationUpdated: function(string,number),
* onEvent: function(!Event)
* onEvent: function(!Event),
* }}
*
* @property {shaka.net.NetworkingEngine} netEngine
Expand All @@ -2816,7 +2816,7 @@ shaka.drm.DrmEngine.PlayerInterface;
/**
* @typedef {{
* kids: !Array<string>,
* type: string
* type: string,
* }}
*
* @property {!Array<string>} kids
Expand Down
2 changes: 1 addition & 1 deletion lib/drm/playready.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ shaka.drm.PlayReady = class {
/**
* @typedef {{
* type: number,
* value: !Uint8Array
* value: !Uint8Array,
* }}
*
* @description
Expand Down
6 changes: 3 additions & 3 deletions lib/hls/hls_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -3259,7 +3259,7 @@ shaka.hls.HlsParser = class {
* drmInfos: !Array<shaka.extern.DrmInfo>,
* keyIds: !Set<string>,
* encrypted: boolean,
* aesEncrypted: boolean
* aesEncrypted: boolean,
* }>}
* @private
*/
Expand Down Expand Up @@ -5190,7 +5190,7 @@ shaka.hls.HlsParser = class {
* firstSequenceNumber: number,
* nextMediaSequence: number,
* nextPart: number,
* loadedOnce: boolean
* loadedOnce: boolean,
* }}
*
* @description
Expand Down Expand Up @@ -5235,7 +5235,7 @@ shaka.hls.HlsParser.StreamInfo;
/**
* @typedef {{
* audio: !Array<shaka.hls.HlsParser.StreamInfo>,
* video: !Array<shaka.hls.HlsParser.StreamInfo>
* video: !Array<shaka.hls.HlsParser.StreamInfo>,
* }}
*
* @description Audio and video stream infos.
Expand Down
2 changes: 1 addition & 1 deletion lib/media/adaptation_set_criteria.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ shaka.media.AdaptationSetCriteria.Factory;
* activeAudioCodec: string,
* activeAudioChannelCount: number,
* preferredAudioCodecs: !Array<string>,
* preferredAudioChannelCount: number
* preferredAudioChannelCount: number,
* }}
*
* @property {string} language
Expand Down
21 changes: 14 additions & 7 deletions lib/media/media_source_engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -2333,9 +2333,13 @@ shaka.media.MediaSourceEngine = class {
* @param {shaka.util.ManifestParserUtils.ContentType} contentType
* @param {string} mimeType
* @param {string} codecs
* @return {{transmuxer: ?shaka.extern.Transmuxer,
* transmuxerMuxed: boolean, basicType: string, codec: string,
* mimeType: string}}
* @return {{
* transmuxer: ?shaka.extern.Transmuxer,
* transmuxerMuxed: boolean,
* basicType: string,
* codec: string,
* mimeType: string,
* }}
* @private
*/
getRealInfo_(contentType, mimeType, codecs) {
Expand Down Expand Up @@ -2406,8 +2410,11 @@ shaka.media.MediaSourceEngine = class {
* @param {string} codecs
* @param {!Map<shaka.util.ManifestParserUtils.ContentType,
* shaka.extern.Stream>} streamsByType
* @return {{type: string, newMimeType: string,
* transmuxer: ?shaka.extern.Transmuxer}}
* @return {{
* type: string,
* newMimeType: string,
* transmuxer: ?shaka.extern.Transmuxer,
* }}
* @private
*/
getInfoAboutResetOrChangeType_(contentType, mimeType, codecs, streamsByType) {
Expand Down Expand Up @@ -2593,7 +2600,7 @@ shaka.media.MediaSourceEngine.createObjectURL = window.URL.createObjectURL;
* @typedef {{
* start: function(),
* p: !shaka.util.PublicPromise,
* uri: ?string
* uri: ?string,
* }}
*
* @summary An operation in queue.
Expand Down Expand Up @@ -2634,7 +2641,7 @@ shaka.media.MediaSourceEngine.ResetMode_ = {
* onMetadata: function(!Array<shaka.extern.ID3Metadata>, number, ?number),
* onEmsg: function(!shaka.extern.EmsgInfo),
* onEvent: function(!Event),
* onManifestUpdate: function()
* onManifestUpdate: function(),
* }}
*
* @summary Player interface
Expand Down
2 changes: 1 addition & 1 deletion lib/media/play_rate_controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ shaka.media.PlayRateController = class {
* getRate: function():number,
* getDefaultRate: function():number,
* setRate: function(number),
* movePlayhead: function(number)
* movePlayhead: function(number),
* }}
*
* @description
Expand Down
2 changes: 1 addition & 1 deletion lib/media/preload_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ shaka.media.PreloadManager = class extends shaka.util.FakeEventTarget {
* networkingEngine: !shaka.net.NetworkingEngine,
* manifestFilterer: !shaka.media.ManifestFilterer,
* allowPrefetch: boolean,
* allowMakeAbrManager: boolean
* allowMakeAbrManager: boolean,
* }}
*
* @property {!shaka.extern.PlayerConfiguration} config
Expand Down
2 changes: 1 addition & 1 deletion lib/media/presentation_timeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ shaka.media.PresentationTimeline = class {
* unscaledStart: number,
* end: number,
* partialSegments: number,
* segmentPosition: number
* segmentPosition: number,
* }}
*
* @description
Expand Down
4 changes: 2 additions & 2 deletions lib/media/quality_observer.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ shaka.media.QualityObserver = class extends shaka.util.FakeEventTarget {
/**
* @typedef {{
* mediaQuality: !shaka.extern.MediaQualityInfo,
* position: !number
* position: !number,
* }}
*
* @description
Expand All @@ -322,7 +322,7 @@ shaka.media.QualityObserver.QualityChangePosition;
* qualityChangePositions:
* !Array<shaka.media.QualityObserver.QualityChangePosition>,
* currentQuality: ?shaka.extern.MediaQualityInfo,
* contentType: !string
* contentType: !string,
* }}
*
* @description
Expand Down
2 changes: 1 addition & 1 deletion lib/media/region_observer.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ shaka.media.RegionObserver.EventListener;
* @typedef {{
* weWere: ?shaka.media.RegionObserver.RelativePosition_,
* weAre: ?shaka.media.RegionObserver.RelativePosition_,
* invoke: shaka.media.RegionObserver.EventListener
* invoke: shaka.media.RegionObserver.EventListener,
* }}
*
* @private
Expand Down
2 changes: 1 addition & 1 deletion lib/media/segment_reference.js
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ shaka.media.AnySegmentReference;
* height: number,
* positionX: number,
* positionY: number,
* width: number
* width: number,
* }}
*
* @property {number} height
Expand Down
Loading