Skip to content

chore: Add trailing commas to all record types #8820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

joeyparrish
Copy link
Member

Now that jsdoc supports this, it will make future diffs cleaner. See #8819 and #1236.

Now that jsdoc supports this, it will make future diffs cleaner.  See shaka-project#8819
@joeyparrish joeyparrish requested a review from avelad June 30, 2025 19:44
@avelad
Copy link
Member

avelad commented Jun 30, 2025

Maybe, we should also modify the externs also

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@joeyparrish joeyparrish merged commit 7c1e31d into shaka-project:main Jun 30, 2025
31 of 33 checks passed
@joeyparrish joeyparrish deleted the trailing-commas branch June 30, 2025 20:36
avelad pushed a commit that referenced this pull request Jul 7, 2025
Now that jsdoc supports this, it will make future diffs cleaner. See
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants