update examples for setting up resource attributes in JS #7252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2025
maryliag
approved these changes
Jul 7, 2025
svrnm
approved these changes
Jul 9, 2025
|
@open-telemetry/demo-approvers PTAL @open-telemetry/javascript-approvers I assume this change also needs to be done in the JS docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue: github.com//issues/7206
The React Native code in the demo is also needs to be updated to match this example code snippet: open-telemetry/opentelemetry-demo#2331
The Frontend code example was already correct in the demo repo so just updated the code snippet to match: https://github.com/open-telemetry/opentelemetry-demo/blob/96b292d5f3281d1bbde0309a8d9325475f356a4b/src/frontend/utils/telemetry/FrontendTracer.ts#L24