Skip to content

update how we grab resource attributes in react native example #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jpmunz
Copy link
Contributor

@jpmunz jpmunz commented Jul 2, 2025

Changes

Based on this issue: open-telemetry/opentelemetry.io#7206, updating the React Native example to use the recommended way to setup resources in JS. Note that this involved updating @opentelemetry/resources to 2.x, I kept the other OTel dependencies at 1.x for now since bringing them all to 2.x would be a larger change and wasn't needed for this particular update but we should do that full upgrade eventually

Docs repo update: open-telemetry/opentelemetry.io#7252

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@jpmunz jpmunz requested a review from a team as a code owner July 2, 2025 21:53
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jpmunz !

@julianocosta89 julianocosta89 merged commit 9bf05fd into open-telemetry:main Jul 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants