Skip to content

dts: bindings: Fix nRF7120 binding #23317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

krish2718
Copy link
Contributor

Fix below issues:

  1. Binding file name should be same as compat
  2. Use specific version for the compat instead of generic Series name.

@krish2718 krish2718 requested a review from a team as a code owner July 16, 2025 07:47
@krish2718 krish2718 requested a review from Hi-Im-David July 16, 2025 07:47
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 16, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 16, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 8da9ac3502056d24eeee54466859a42bf4cd8cae
zephyr: PR head: bc6d4d7b667e68d807901fcd31413cf6aa3c0b19

more details

sdk-nrf:

PR head: 8da9ac3502056d24eeee54466859a42bf4cd8cae
merge base: e87c8838e956949c0aa1a3e5d5c040334ce8cf4f
target head (main): e87c8838e956949c0aa1a3e5d5c040334ce8cf4f
Diff

zephyr:

PR head: bc6d4d7b667e68d807901fcd31413cf6aa3c0b19
merge base: ef52a5ec69622e202595a38c26333ebea3ed87b5
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (14)
dts
│  ├── bindings
│  │  ├── wifi
│  │  │  │ nordic,nrf7120.yaml
│  ├── common
│  │  ├── nordic
│  │  │  │ nrf7120_enga.dtsi
west.yml
zephyr
│  ├── drivers
│  │  ├── flash
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── Kconfig.nrf_mramc
│  │  │  │ soc_flash_nrf_mramc.c
│  │  ├── wifi
│  │  │  ├── nrf_wifi
│  │  │  │  │ Kconfig.nrfwifi
│  ├── dts
│  │  ├── bindings
│  │  │  ├── flash_controller
│  │  │  │  │ nordic,nrf-mramc.yaml
│  ├── modules
│  │  ├── hal_nordic
│  │  │  ├── nrfx
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.logging
│  │  │  │  │ nrfx_kconfig.h
│  │  ├── nrf_wifi
│  │  │  ├── bus
│  │  │  │  │ Kconfig

Outputs:

Toolchain

Version: 684b32e022
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:684b32e022_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 801
    • sdk-zephyr test count: 1581
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-find-my
    • ✅ test-low-level
    • ✅ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@krish2718 krish2718 requested a review from bama-nordic July 17, 2025 19:24
@krish2718
Copy link
Contributor Author

@nrfconnect/ncs-co-drivers ping.

@krish2718
Copy link
Contributor Author

@nrfconnect/ncs-co-drivers ping.

@anangl @bjarki-andreasen can one of you please review?

@krish2718 krish2718 force-pushed the fix_nrf71_binding branch from 7f8d1e7 to 4f24336 Compare July 23, 2025 10:03
@krish2718 krish2718 requested review from a team as code owners July 23, 2025 10:03
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 23, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@ef52a5e nrfconnect/sdk-zephyr@bc6d4d7 (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

You can find the documentation preview for this PR here.

Fix below issues:

1. Binding file name should be same as compat
2. Use specific version for the compat instead of generic Series name.

Signed-off-by: Chaitanya Tata <[email protected]>
Pull corresponding driver change for DTS compat rename.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 force-pushed the fix_nrf71_binding branch from 4f24336 to 8da9ac3 Compare July 23, 2025 15:14
@NordicBuilder NordicBuilder removed the DNM label Jul 23, 2025
@nordicjm nordicjm merged commit 59bc269 into nrfconnect:main Jul 24, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants