-
Notifications
You must be signed in to change notification settings - Fork 54
ENH: Add n4_only
workflow -- to skip brain extraction
#435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 59.98% 55.68% -4.31%
==========================================
Files 57 57
Lines 5448 5675 +227
Branches 644 647 +3
==========================================
- Hits 3268 3160 -108
- Misses 2137 2456 +319
- Partials 43 59 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to avoid future iterations to add the binary dilation, let's do it now.
n4_only
workflow -- to skip brain extraction
Co-Authored-By: Oscar Esteban <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one detail left...
Co-Authored-By: Oscar Esteban <[email protected]>
wf.connect([ | ||
(inputnode, inu_n4_final, [('in_files', 'input_image')]), | ||
(inputnode, thr_brainmask, [(('in_files', _pop), 'in_file')]), | ||
(thr_brainmask, outputnode, [('out_mask', 'out_mask')]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the dilated mask be output, or the undilated one (which is what we're doing here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the undilated. I believe we should refactor the Binarize interface so that it can do the binary closing and opening, which will give a smoother mask (and that will be good for the dilated mask too).
Allows skipping brain extraction with n4_only workflow.
See: nipreps/smriprep#116
I think the main remaining todo is this comment from @oesteban: