Skip to content

fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION #5408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/nodejs/esm-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,19 @@ const tryImportAndRequire = async (file, esmDecorator) => {
const requireModule = async (file, esmDecorator) => {
try {
return require(file);
} catch (err) {
// Import if require fails.
return dealWithExports(await formattedImport(file, esmDecorator));
} catch (requireErr) {
// Fallback to import() if require() fails.
try {
return dealWithExports(await formattedImport(file, esmDecorator));
} catch (importErr) {
// If a --require module throws in a Node.js version that doesn't yet support .ts files,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add tests for a specific range of Node versions? We should have an automated test that enters this branch of code for sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(discussed 1:1) Agreed. It really hurts me not covering this behavior with tests 🙃. We'll block this on #5407: once that lands, I can add an integration/similar test for a specific Node.js version or two.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref also #5413 which also adds an if-else here and adds tests for the new branch

// the fallback import() will throw an uninformative error about the file extension.
// What we actually care about is the original require() error.
// See: https://github.com/mochajs/mocha/issues/5393
throw /\.(?:c|m)?ts$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex is already weird enough, I'm in favor of minor repetition if it supports clarity

Suggested change
throw /\.(?:c|m)?ts$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION"
throw /\.(cts|mts|ts)$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION"

? requireErr
: importErr;
}
}
}

Expand Down
Loading