fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
changed the title
mark-wiemer
requested changes
Jul 29, 2025
| try { | ||
| return dealWithExports(await formattedImport(file, esmDecorator)); | ||
| } catch (importErr) { | ||
| // If a --require module throws in a Node.js version that doesn't yet support .ts files, |
There was a problem hiding this comment.
Maybe we can add tests for a specific range of Node versions? We should have an automated test that enters this branch of code for sure
There was a problem hiding this comment.
(discussed 1:1) Agreed. It really hurts me not covering this behavior with tests 🙃. We'll block this on #5407: once that lands, I can add an integration/similar test for a specific Node.js version or two.
There was a problem hiding this comment.
Ref also #5413 which also adds an if-else here and adds tests for the new branch
mark-wiemer
reviewed
Jul 29, 2025
| // the fallback import() will throw an uninformative error about the file extension. | ||
| // What we actually care about is the original require() error. | ||
| // See: https://github.com/mochajs/mocha/issues/5393 | ||
| throw /\.(?:c|m)?ts$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION" |
There was a problem hiding this comment.
Regex is already weird enough, I'm in favor of minor repetition if it supports clarity
Suggested change
| throw /\.(?:c|m)?ts$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION" | |
| throw /\.(cts|mts|ts)$/.test(file) || importErr?.code === "ERR_UNKNOWN_FILE_EXTENSION" |
JoshuaKGoldberg
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
ERR_UNKNOWN_FILE_EXTENSION#5393status: accepting prsOverview
Adds in a special-case
try/catch->throw. If the file being imported is a.cts,.mts, or.tsand the caught error fromimport()is for an unknown file extension, we know it's from a Node.js version that doesn't support those file extensions. In that case we'll want to throw the original informativerequire()error per #5393.As with #5384, doesn't add unit tests - this is a weird tricky area to test. I'm not clear on what a good way to do it is.
💖