-
Notifications
You must be signed in to change notification settings - Fork 6.7k
CI: Simplify running playbooks as collection + various CI Fixes #12295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
acfa8a9
to
5d2cdbf
Compare
/label tide/merge-method-merge |
This allows to use kubespray_defaults (once) instead of redefining defaults in the tests. Test test files becomes imported tasks rather thand standalone playbooks.
(This makes it easier to source that var in CI tests)
Avoids putting whole pod spec in loop label
Filter pod to describe / logs only the broken ones.
/retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and confirmed that the implementation is fine.
Very little little review.
sonobuoy_mode: Quick | ||
- name: Download sonobuoy | ||
get_url: | ||
url: "https://github.com/heptio/sonobuoy/releases/download/v{{ sonobuoy_version }}/sonobuoy_{{ sonobuoy_version }}_linux_{{ sonobuoy_arch }}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: "https://github.com/heptio/sonobuoy/releases/download/v{{ sonobuoy_version }}/sonobuoy_{{ sonobuoy_version }}_linux_{{ sonobuoy_arch }}.tar.gz" | |
url: "https://github.com/vmware-tanzu/sonobuoy/releases/download/v{{ sonobuoy_version }}/sonobuoy_{{ sonobuoy_version }}_linux_{{ sonobuoy_arch }}.tar.gz" |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #12293
Special notes for your reviewer:
Does this PR introduce a user-facing change?: