Skip to content

CI: Add a test for scale.yml #12285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jun 6, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2025
@VannTen VannTen force-pushed the ci/test_scale_playbook branch from 6f7b9e9 to db7c67a Compare June 6, 2025 07:50
@VannTen
Copy link
Contributor Author

VannTen commented Jun 6, 2025

/retest

1 similar comment
@ant31
Copy link
Contributor

ant31 commented Jun 10, 2025

/retest

@ant31
Copy link
Contributor

ant31 commented Jun 10, 2025

thanks it's a good addition

@VannTen VannTen force-pushed the ci/test_scale_playbook branch from db7c67a to 63842a6 Compare June 10, 2025 15:42
VannTen added 4 commits June 12, 2025 10:11
This allows to use kubespray_defaults (once) instead of redefining
defaults in the tests.
Test test files becomes imported tasks rather thand standalone
playbooks.
(This makes it easier to source that var in CI tests)
@VannTen
Copy link
Contributor Author

VannTen commented Jun 12, 2025

Depend on #12295

VannTen added 3 commits June 12, 2025 16:23
Avoids putting whole pod spec in loop label
Filter pod to describe / logs only the broken ones.
@VannTen VannTen force-pushed the ci/test_scale_playbook branch from 63842a6 to 79c8e26 Compare June 12, 2025 14:24
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
@VannTen VannTen marked this pull request as ready for review June 14, 2025 20:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from cyclinder June 14, 2025 20:46
@VannTen
Copy link
Contributor Author

VannTen commented Jun 14, 2025

/hold
#12295 should merge before

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2025
@VannTen
Copy link
Contributor Author

VannTen commented Jun 14, 2025

/cc @ant31

@k8s-ci-robot k8s-ci-robot requested a review from ant31 June 14, 2025 20:47
@ant31
Copy link
Contributor

ant31 commented Jun 16, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants