-
Notifications
You must be signed in to change notification settings - Fork 48
FIX remove link to resource_tracker._pid in child processes #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for investigating that this fast @tomMoral From what I've read from the code so far, this looks good to me (+ the extra resulting simplification on tracker_args -> tracker_fd). What I intended to do initially is to try to monkey patch This is much simpler and indeed setting (The ci failing on windows looks like an actual remaining bug.) |
Yes, it is safe to assume that we can modify private info. |
I have investigated the remaining issue in a windows VM. The current issue arises when the parent process garbage collects the loky resource tracker. The There are no issues with the resource tracker from multiprocessing library. Since this remaining windows issue is about the loky resource tracker, there's an easy fix: a quick workaround to could be to override loky resource tracker del method to just do nothing (or, only do nothing on windows). So far I don't know why the loky resource tracker process is cleant before the garbage collection of the resource tracker object. If we can find out maybe there would be a cleaner fix. |
Fix for joblib/joblib#1708.