Fix BLE byte counter regression introduced in 9.0.0

[sensei-hacker]

User description

Summary

Fixes BLE connection byte counter always showing 0, which also caused MSP request timeouts over BLE.

See #2538

Root Cause

In 8.0.0, Connection.addOnReceiveListener() called both _onReceiveListeners.push() AND addOnReceiveCallback(), which registered the byte counter callback in BLE's separate listener array. In 9.0.0 this was changed to only push to _onReceiveListeners (to avoid duplication in Serial/TCP/UDP which share the same array). BLE was the only connection type with a separate array, so it silently lost the byte counter callback.

Changes

• Removed BLE's separate _onCharateristicValueChangedListeners array
• Changed addOnReceiveCallback() and removeOnReceiveCallback() to use the base class _onReceiveListeners array, matching the pattern Serial already uses
• Notification handler now dispatches to _onReceiveListeners directly

Testing

• Could not test with BLE hardware (none available in this environment)
• Code review performed with inav-code-review agent — no critical issues
• Logic verified against Serial connection implementation which uses the same pattern
• Requesting testing from someone with BLE hardware (e.g. SpeedyBee or Nordic NRF adapter)

Note on Debug Logging

This PR intentionally includes temporary [BLE FIX] console.log statements (4 total, marked with TODO comments) to help verify the fix when tested with real BLE hardware. These should be removed in a follow-up once the fix is confirmed working.

---

PR Type

Bug fix

---

Description

• Fixes BLE byte counter regression showing zero bytes received

• Aligns BLE connection with Serial pattern using shared listener array

• Removes BLE-specific characteristic listener array causing callback loss

• Adds temporary debug logging to verify fix with BLE hardware

---

Diagram Walkthrough

flowchart LR
  A["BLE Notification Handler"] -->|"dispatch to"| B["_onReceiveListeners array"]
  B -->|"calls"| C["Byte Counter Callback"]
  C -->|"increments"| D["_bytesReceived counter"]
  B -->|"calls"| E["MSP Parser Callback"]
  E -->|"processes"| F["MSP Responses"]

Loading

File Walkthrough

Relevant files

Bug fix

connectionBle.js Align BLE listener pattern with Serial implementation        js/connection/connectionBle.js Removed _onCharateristicValueChangedListeners array from constructor Changed addOnReceiveCallback() to push to _onReceiveListeners instead of BLE-specific array Updated removeOnReceiveCallback() to filter _onReceiveListeners instead of BLE-specific array Modified notification handler to dispatch to _onReceiveListeners directly with debug logging Added four temporary [BLE FIX] console.log statements marked with TODO for removal after testing +18/-8

---

[qodo-code-review]

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.