Skip to content

Conversation

@smsnvc
Copy link
Contributor

@smsnvc smsnvc commented Dec 21, 2025

User description

Hi @MrD-RC , @sensei-hacker ,

CC @bfmvsa

Thanks for your work.

Here are the slight fixups of the Ukrainian translations you added and new strings that were not tranlsated yet.
Hope they become a part of INAV 9 configurator.


PR Type

Documentation


Description

  • This description is generated by an AI tool. It may have inaccuracies

  • Updates Ukrainian translations for INAV 9 RC configurator

  • Improves terminology consistency (датчик/сенсор, вказівник/індикатор)

  • Refines phrasing for better clarity and natural Ukrainian language

  • Adds new translation strings for JavaScript programming tab

  • Introduces MSP warning message for UART port configuration


Diagram Walkthrough

flowchart LR
  A["Ukrainian messages.json"] -- "Terminology refinements" --> B["Improved translations"]
  A -- "New strings added" --> C["JavaScript tab labels"]
  A -- "Configuration help text" --> D["MSP UART warning"]
Loading

File Walkthrough

Relevant files
Documentation
messages.json
Ukrainian translation updates and new strings                       

locale/uk/messages.json

  • Refines terminology consistency (датчик/сенсор, вказівник/індикатор,
    одиниці/паливо)
  • Improves phrasing in FrSky telemetry, OSD, and mixer configuration
    help texts
  • Adds four new translation strings for JavaScript programming tab
    (tabJavaScriptProgramming, javascriptTranspile, javascriptLoad,
    javascriptSave, javascriptClear)
  • Adds new MSP UART warning message (portsMSPWarning) for port
    configuration
  • Updates logic activator label from "Активний" to "Працює коли"
+29/-11 

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 21, 2025

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

Comment on lines +1294 to +1296
"portsMSPWarning": {
"message": "<strong>Увага:</strong><p>Увімкнення MSP більш ніж на двох UART-портах може заважати роботі USB-з’єднання. Рекомендується вимкнути MSP на порту, де він не потрібен.</p>"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Normalize the embedded HTML to a single, well-formed block (avoid mixing inline <strong> with a separate <p> block) to prevent inconsistent rendering across containers. [Learned best practice, importance: 6]

Suggested change
"portsMSPWarning": {
"message": "<strong>Увага:</strong><p>Увімкнення MSP більш ніж на двох UART-портах може заважати роботі USB-з’єднання. Рекомендується вимкнути MSP на порту, де він не потрібен.</p>"
},
"portsMSPWarning": {
"message": "<p><strong>Увага:</strong> Увімкнення MSP більш ніж на двох UART-портах може заважати роботі USB-з’єднання. Рекомендується вимкнути MSP на порту, де він не потрібен.</p>"
}

@sensei-hacker sensei-hacker changed the base branch from master to maintenance-9.x December 21, 2025 14:36
@sensei-hacker
Copy link
Member

Thanks @smsnvc !

@sensei-hacker
Copy link
Member

@smsnvc There are a couple more strings I had added in maintenance-9.x
Can you kindly click on the "resolve conflicts" button and set them however they should be?

@smsnvc
Copy link
Contributor Author

smsnvc commented Dec 21, 2025

@sensei-hacker , done.
Your translation was quite good, only minor tweaks from my side.

@sensei-hacker sensei-hacker merged commit c85b75a into iNavFlight:maintenance-9.x Dec 21, 2025
6 checks passed
@sensei-hacker
Copy link
Member

Your translation was quite good, only minor tweaks from my side.

Large language models like Claude and ChatGPT are really bad at a lot of things. But one thing large language models are pretty good at is language. :)

sensei-hacker added a commit to sensei-hacker/inav-configurator that referenced this pull request Dec 21, 2025
Updates locale/uk/messages.json to use translations from PR iNavFlight#2491
for keys that exist in both PRs, resolving merge conflicts.

Changes:
- tabJavaScriptProgramming: Use 'на JavaScript' style
- javascriptBetaWarning: Use 'Пишіть на JavaScript'
- javascriptEditorTitle: Use 'щоб вставити'
- javascriptTranspile: Use 'Транспілювати в INAV'

All unique keys from this PR are retained.
sensei-hacker added a commit to sensei-hacker/inav-configurator that referenced this pull request Dec 21, 2025
Complete the conflict resolution by updating two more Ukrainian
translations to match PR iNavFlight#2491:
- javascriptLoad: Use 'з польотного контролера' (from flight controller)
- javascriptSave: Use 'до польотного контролера' (to flight controller)

This completes the alignment with PR iNavFlight#2491's Ukrainian translations.
sensei-hacker added a commit to sensei-hacker/inav-configurator that referenced this pull request Dec 21, 2025
Resolved conflicts in locale/uk/messages.json by keeping our versions
which now match PR iNavFlight#2491's Ukrainian translations.
sensei-hacker added a commit to sensei-hacker/inav-configurator that referenced this pull request Dec 22, 2025
During merge conflict resolution in dc4d17b, the portsMSPWarning
translation key from PR iNavFlight#2491 was accidentally deleted. This commit
restores it to match upstream/maintenance-9.x.

The portsMSPWarning key provides a warning message about enabling
MSP on more than two UART ports potentially interfering with USB
connection.
sensei-hacker added a commit to sensei-hacker/inav-configurator that referenced this pull request Dec 22, 2025
…s work

Remove all changes to translations that were set by PR iNavFlight#2491. Our PR
should only add new JavaScript Programming keys, not modify existing
translations from PR iNavFlight#2491.

This resets locale/uk/messages.json to match upstream/maintenance-9.x
exactly, preserving all of PR iNavFlight#2491's translation work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants