Run mDNS broadcast asynchronously #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run mDNS in a goroutine so the landing page server starts also in cases when the outbound IP address can't be determined or the mDNS server fails to start for another reason. This is easy to reproduce when the device has no network connectivity when it starts for the first time. In such case, the landing page errors with "connect: network is unreachable" and never starts after the cable is reconnected, leaving port 8123 unreachable until full Core is downloaded. Since mDNS is not mission-critical, we shouldn't block the webserver from starting and just start the mDNS asynchronously.
sairon
added a commit
that referenced
this pull request
May 20, 2025
Outstanding comment mentions the hacky way for obtaining the outbound IP address should be replaced by API from home-assistant/supervisor#2115. Poll this API periodically with 5s retry interval in case the IP can't be determined or parsed from the response. This still ignores IPv6-only deployment of HA, however, in that case the landing page should still be reachable, just not discoverable through mDNS (combined with #164).
sairon
added a commit
that referenced
this pull request
May 21, 2025
* Poll for address of Supervisor default interface for mDNS URL Outstanding comment mentions the hacky way for obtaining the outbound IP address should be replaced by API from home-assistant/supervisor#2115. Poll this API periodically with 5s retry interval in case the IP can't be determined or parsed from the response. This still ignores IPv6-only deployment of HA, however, in that case the landing page should still be reachable, just not discoverable through mDNS (combined with #164). * Implement setSupervisorAuthHeader for setting bearer token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run mDNS in a goroutine so the landing page server starts also in cases when the outbound IP address can't be determined or the mDNS server fails to start for another reason.
This is easy to reproduce when the device has no network connectivity when it starts for the first time. In such case, the landing page errors with "connect: network is unreachable" and never starts after the cable is reconnected, leaving port 8123 unreachable until full Core is downloaded.
Since mDNS is not mission-critical, we shouldn't block the webserver from starting and just start the mDNS asynchronously.