Poll for address of Supervisor default interface for mDNS URL #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding comment mentions the hacky way for obtaining the outbound IP address should be replaced by API from home-assistant/supervisor#2115. Poll this API periodically with 5s retry interval in case the IP can't be determined or parsed from the response. This still ignores IPv6-only deployment of HA, however, in that case the landing page should still be reachable, just not discoverable through mDNS (combined with #164).
agners
reviewed
May 21, 2025
| supervisorHost := getSupervisorHost() | ||
|
|
||
| client := &http.Client{} | ||
| req, err := http.NewRequest("GET", "http://"+supervisorHost+"/network/interface/default/info", nil) |
There was a problem hiding this comment.
Maybe a job for net/url to build the URL? 🤔
mdns.go
Outdated
| return nil, fmt.Errorf("can't create request to Supervisor: %s", err) | ||
| } | ||
|
|
||
| req.Header.Add("Authorization", "Bearer "+os.Getenv("SUPERVISOR_TOKEN")) |
There was a problem hiding this comment.
Lets make this a helper function similar to getSupervisorHost()
There was a problem hiding this comment.
You mean something like setSupervisorAuthHeader(req)?
agners
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outstanding comment mentions the hacky way for obtaining the outbound IP address should be replaced by API from home-assistant/supervisor#2115. Poll this API periodically with 5s retry interval in case the IP can't be determined or parsed from the response.
This still ignores IPv6-only deployment of HA, however, in that case the landing page should still be reachable, just not discoverable through mDNS (combined with #164).