Skip to content

Buildbot fixes #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 4, 2025
Merged

Buildbot fixes #8706

merged 12 commits into from
Aug 4, 2025

Conversation

alexreinking
Copy link
Member

@alexreinking alexreinking commented Aug 3, 2025

A batch of updates to fix the buildbots / CI after updating the workers.

  1. Upgrade tflite to a newer (the newest) version that doesn't "require" prehistoric CMake (CMake 4.x errors, saying that support has been dropped for <3.5).
  2. Remove a cursed hack for removing the "local" version string from the development pip packages in CI.
  3. Add some missing DEPENDS entries that I discovered (and then audited for) upon attempting an incremental build after upgrading tflite.
  4. Improve the CMake helpers' search for component dependencies.
  5. Add onnx to a new set of app-specific dependencies

Potentially more to come...

@alexreinking
Copy link
Member Author

Hannk doesn't build anymore. Investigating...

@alexreinking
Copy link
Member Author

I'll note that these are real issues that updating the buildbot workers exposed, rather than issues with the buildbot configuration.

@alexreinking alexreinking force-pushed the deps/upgrade-flatbuffers branch from 4104854 to 9af0862 Compare August 3, 2025 15:09
Copy link
Contributor

@mcourteaux mcourteaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the missing NEON2SSE comment for TF Lite, LGTM.

@alexreinking
Copy link
Member Author

Happy to see the CI changes are working out. The failures here are either spurious (performance testing errors) or unrelated to this PR (LLVM main codegen issues).

@mcourteaux
Copy link
Contributor

This looks great! Thanks a lot for the hard work this weekend, Alex! The failures seem consistent across all machines. I'm in favor of landing this ASAP, and we'll sort out this new Wasm issue later.

@alexreinking alexreinking merged commit 4d8c660 into main Aug 4, 2025
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants