Add missing DEPENDS entries in add_custom_command

Author: alexreinking

src/CMakeLists.txt

@@ -551,7 +551,7 @@ if (WITH_SERIALIZATION)
     add_custom_command(
         OUTPUT "${fb_header}"
         COMMAND flatbuffers::flatc --cpp --cpp-std C++17 --no-union-value-namespacing --keep-prefix --filename-suffix ".fbs" -o "${fb_dir}" "${fb_def}"
-        DEPENDS "${fb_def}"
+        DEPENDS flatbuffers::flatc "${fb_def}"
         VERBATIM
     )
     add_custom_target(generate_fb_header DEPENDS "${fb_header}")

src/runtime/CMakeLists.txt

@@ -280,14 +280,14 @@ foreach (i IN LISTS RUNTIME_CPP)
             else()
                 add_custom_command(OUTPUT "${LL}"
                                    COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} ${CMAKE_C_COMPILER_LAUNCHER} $<TARGET_FILE:clang> ${clang_flags} -o "${LL}" "$<SHELL_PATH:${SOURCE}>"
-                                   DEPENDS "${SOURCE}"
+                                   DEPENDS $<TARGET_NAME:clang> "${SOURCE}"
                                    DEPFILE "${basename}.d"
                                    VERBATIM)
             endif()
 
             add_custom_command(OUTPUT "${BC}"
                                COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:llvm-as> "${LL}" -o "${BC}"
-                               DEPENDS "${LL}"
+                               DEPENDS $<TARGET_NAME:llvm-as> "${LL}"
                                VERBATIM)
 
             add_custom_command(OUTPUT "${INITMOD}"
@@ -314,7 +314,7 @@ foreach (i IN LISTS RUNTIME_LL)
 
     add_custom_command(OUTPUT "${BC}"
                        COMMAND ${CMAKE_CROSSCOMPILING_EMULATOR} $<TARGET_FILE:llvm-as> "${LL_TRANSFORMED}" -o "${BC}"
-                       DEPENDS "${LL_TRANSFORMED}"
+                       DEPENDS $<TARGET_NAME:llvm-as> "${LL_TRANSFORMED}"
                        VERBATIM)
     add_custom_command(OUTPUT "${INITMOD}"
                        COMMAND binary2cpp "halide_internal_initmod_${i}_ll" < "${BC}" > "${INITMOD}"

test/generator/CMakeLists.txt

@@ -80,7 +80,7 @@ function(add_wasm_executable TARGET)
 
     add_custom_command(OUTPUT "${TARGET}.wasm" "${TARGET}.js"
                        COMMAND ${EMCC} ${EMCC_FLAGS} ${INCLUDES} ${SRCS} ${DEPS} -o "${TARGET}.js"
-                       DEPENDS ${SRCS} ${DEPS}
+                       DEPENDS ${EMCC} ${SRCS} ${DEPS}
                        VERBATIM)
 
     add_custom_target("${TARGET}" ALL