fix(set-head): query for specific version of the object in the index when verifying existence of the object version before setting head version #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when verifying existence of the object version before setting head version
cgarzonmoreno-godaddy
approved these changes
May 19, 2025
sgore-godaddy
changed the title
mgross1-godaddy
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue was that the Dynamo DB query was querying for ALL objects by keyname in an env for checking existence of a version before setting head version. As the data in the tables grew the result does not return all of the version for an object (as it is paginated).
The change here is to query for a specific version of the object in the index when verifying that we have a matching version in the database, this will result in a small query result and will only return when a matching version is existing in the database.
Changelog
Test Plan