fix(set-head): query for speicific version of the object in the index when verifying existence of the object version before setting head version (#151)

Author: sgore-godaddy

lib/plugins/object.js

@@ -457,6 +457,38 @@ module.exports = fp(
       }
     );
 
+    /**
+     * Check if an Object version exists
+     *
+     * @param {Object} opts Method parameters
+     * @param {string} opts.name Object name
+     * @param {string} opts.env Environment
+     * @param {string} opts.version Object versions
+     * @returns {Promise<boolean>} True if the object version exists, false otherwise
+     */
+    fastify.decorate(
+      'hasObjectVersion',
+      async function hasObjectVersion({ name, env, version }) {
+        const params = {
+          IndexName: 'keyname-env-index',
+          KeyConditionExpression: 'keyname = :name AND env = :env',
+          FilterExpression: 'version = :version',
+          ExpressionAttributeValues: {
+            ':name': name,
+            ':env': env,
+            ':version': version
+          },
+          TableName: OBJECT_VARIANTS_TABLE
+        };
+        const { Items: items } = await dynamo.query(params).promise();
+        if (!items || items.length === 0) {
+          return false;
+        }
+        // Check if the version exists in the list
+        return items.some((item) => item.version === version);
+      }
+    );
+
     fastify.decorate(
       'putObjectVariant',
       /**

lib/routes/objects.js

@@ -647,9 +647,9 @@ module.exports =
             headVersion = fromEnvVersion.headVersion;
           }
 
-          const [obj, objVersions] = await Promise.all([
+          const [obj, hasObjectVersion = false] = await Promise.all([
             fastify.getObject({ name, env }),
-            fastify.getAllObjectVersions({ name, env })
+            fastify.hasObjectVersion({ name, env, version: headVersion })
           ]);
 
           if (!obj) {
@@ -658,7 +658,7 @@ module.exports =
             );
           }
 
-          if (!objVersions.includes(headVersion)) {
+          if (!hasObjectVersion) {
             throw fastify.httpErrors.notFound(
               `Version ${headVersion} not found in '${env}'`
             );