Skip to content

Fix a 404 URL #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Fix a 404 URL #614

merged 1 commit into from
Jul 9, 2025
+1 −1

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jul 9, 2025

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov mentioned this pull request Jul 9, 2025
Merged
9 tasks
@atodorov atodorov merged commit 8ea21ae into dev Jul 9, 2025
32 checks passed
@atodorov atodorov deleted the fix_404_url branch July 9, 2025 07:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025

For full LLVM coverage report click here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@beqaabu beqaabu beqaabu approved these changes

@marshacb marshacb Awaiting requested review from marshacb

@BradleyOlson64 BradleyOlson64 Awaiting requested review from BradleyOlson64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @DylanVerstraete @beqaabu