Skip to content

Reverts default base fee back #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2025
Merged

Reverts default base fee back #613

merged 2 commits into from
Jul 9, 2025

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Jul 8, 2025

This reverts commit 05fa652.

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

DylanVerstraete
DylanVerstraete previously approved these changes Jul 8, 2025
View reviewed changes
atodorov
atodorov previously approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however why are we reverting this? We don't want it anymore ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025

For full LLVM coverage report click here!

marshacb
marshacb previously approved these changes Jul 8, 2025
View reviewed changes
@beqaabu
Copy link
Contributor Author

beqaabu commented Jul 8, 2025

LGTM, however why are we reverting this? We don't want it anymore ?

nope, product doesn't want large fees

@beqaabu beqaabu dismissed stale reviews from marshacb, atodorov, and DylanVerstraete via 4b29bf0 July 9, 2025 07:12
atodorov
atodorov approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FTR MegaLinter issues fixed in #614

@beqaabu beqaabu force-pushed the revert-base-fee branch from 4b29bf0 to 047e920 Compare July 9, 2025 07:58
@beqaabu beqaabu merged commit 3fd8937 into dev Jul 9, 2025
52 of 53 checks passed
@beqaabu beqaabu deleted the revert-base-fee branch July 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

@marshacb marshacb marshacb left review comments

@DylanVerstraete DylanVerstraete DylanVerstraete left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beqaabu @atodorov @marshacb @DylanVerstraete