Skip to content

W-18895431 test: improve FieldModifierValidator test for virtual modifiers #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ describe('FieldModifierValidator', () => {
});

test('should reject virtual fields', () => {
// Note: 'virtual' is valid for classes/methods but NOT for fields in Apex.
// Virtual inner classes are handled by ClassModifierValidator, not FieldModifierValidator.
const classSymbol = {
kind: SymbolKind.Class,
modifiers: createSymbolModifiers(),
Expand All @@ -228,6 +230,35 @@ describe('FieldModifierValidator', () => {
expect(modifiers.isVirtual).toBe(false);
});

test('should allow valid field modifiers in inner classes', () => {
// This test ensures fields in inner classes follow the same validation rules
// as fields in outer classes. The parsing of 'virtual' inner classes is
// handled at the grammar level (now fixed in BaseApexParser.g4).
const innerClassSymbol = {
kind: SymbolKind.Class,
modifiers: createSymbolModifiers({
visibility: SymbolVisibility.Public,
isVirtual: true, // This is valid for classes, not fields
}),
} as TypeSymbol;

const validFieldModifiers = createSymbolModifiers({
visibility: SymbolVisibility.Public,
isStatic: true,
isFinal: false,
});

FieldModifierValidator.validateFieldVisibilityModifiers(
validFieldModifiers,
ctx,
innerClassSymbol,
errorReporter,
);

expect(errorReporter.errors.length).toBe(0);
expect(errorReporter.warnings.length).toBe(0);
});

test('should reject override fields', () => {
const classSymbol = {
kind: SymbolKind.Class,
Expand Down