Skip to content

feat(viz-type): Ag grid table plugin Integration #33517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 157 commits into from
Jul 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
157 commits
Select commit Hold shift + click to select a range
7a9f687
Test fork commit
nelsondrew Apr 9, 2025
1cec095
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 Apr 16, 2025
696d5d9
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 Apr 25, 2025
672c16f
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 Apr 29, 2025
3df058e
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 Apr 29, 2025
dc5820d
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 1, 2025
dce9fe3
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 4, 2025
7f51dca
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 11, 2025
e88e98d
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 14, 2025
4e92bb6
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 16, 2025
6d6d237
Merge branch 'master' of https://github.com/apache/superset
amaannawab923 May 18, 2025
dc55f3f
Scaffolding
amaannawab923 May 18, 2025
75076b5
Reverting ag grid versions
amaannawab923 May 18, 2025
0eea6ab
cleaned up ag table chart
amaannawab923 May 18, 2025
139db51
Memoisation
amaannawab923 May 18, 2025
7296c70
Quick search filter client side
amaannawab923 May 18, 2025
1435f70
Quick search filter client side
amaannawab923 May 18, 2025
f6568d7
col def correction
amaannawab923 May 18, 2025
41d53d8
Include Search
amaannawab923 May 18, 2025
2a1c5cb
Cleanup
amaannawab923 May 18, 2025
cdfab49
Removing unnecessary files
amaannawab923 May 19, 2025
51270b8
Transform props change
amaannawab923 May 19, 2025
74436e5
Transform props correction
amaannawab923 May 19, 2025
c12432f
Viz type inclusion
amaannawab923 May 19, 2025
eff6584
Control panel for ag grid table
amaannawab923 May 19, 2025
bca41bf
Making pagination work
amaannawab923 May 19, 2025
9abe433
Unused vars
amaannawab923 May 19, 2025
46d0162
license
amaannawab923 May 19, 2025
155965e
build
amaannawab923 May 19, 2025
55699c1
re running ci
amaannawab923 May 20, 2025
97dfd3e
Removing percent metrics from control panel validations
amaannawab923 May 22, 2025
0301a51
Search icon ant
amaannawab923 Jun 1, 2025
98315ad
Merge branch 'master' of https://github.com/apache/superset into feat…
amaannawab923 Jun 1, 2025
de461d6
Manual pagination ux
amaannawab923 Jun 1, 2025
23cf929
Server pagination manual controls
amaannawab923 Jun 1, 2025
5bbafe9
Manual pagination Completed
amaannawab923 Jun 1, 2025
730e177
Page Size Change
amaannawab923 Jun 1, 2025
3a5132c
Search Select dropdown for ag grid
amaannawab923 Jun 1, 2025
f609183
Search by dropdown
amaannawab923 Jun 1, 2025
24dfa51
Ux correction
amaannawab923 Jun 1, 2025
04ffe8e
Server side search
amaannawab923 Jun 1, 2025
600826f
Maintain search focus
amaannawab923 Jun 1, 2025
a3f7df3
value formatter correction
amaannawab923 Jun 1, 2025
e59a89a
Parity
amaannawab923 Jun 2, 2025
39f653e
Styled container
amaannawab923 Jun 2, 2025
343a98f
Moving sort logic to utils
amaannawab923 Jun 2, 2025
7b9b682
Percent metrics
amaannawab923 Jun 2, 2025
ea9aa4e
Own state sync up
amaannawab923 Jun 2, 2025
3380b1d
Grid height for client side pagination
amaannawab923 Jun 2, 2025
674bc08
Validation dependancy check
amaannawab923 Jun 2, 2025
aef6cf7
Column header guard clauses for ag grid
amaannawab923 Jun 2, 2025
cfc4266
Restrict sort event
amaannawab923 Jun 2, 2025
655ff0e
Clicked header label
amaannawab923 Jun 2, 2025
db08cf7
license
amaannawab923 Jun 2, 2025
811d40e
Ununsed import
amaannawab923 Jun 2, 2025
299f12d
Resync
amaannawab923 Jun 2, 2025
746cd9d
control panel as per table chart
amaannawab923 Jun 2, 2025
673ff26
Custom header base
amaannawab923 Jun 3, 2025
e82cca3
Custom header with column filter instance
amaannawab923 Jun 3, 2025
cecd2a3
Refactor
amaannawab923 Jun 3, 2025
211068d
Custom header with filter & 3 dots
amaannawab923 Jun 3, 2025
12c62cd
Sorting via column menu
amaannawab923 Jun 3, 2025
ba22a89
Removing logs
amaannawab923 Jun 3, 2025
dea3aa4
commenting unusable options
amaannawab923 Jun 3, 2025
3a54514
Fix typescript error
amaannawab923 Jun 3, 2025
b082719
is cell filterable
amaannawab923 Jun 3, 2025
d73a977
Cross filter scaffolding
amaannawab923 Jun 3, 2025
33c1634
cell background
amaannawab923 Jun 3, 2025
f7ab2fc
Custom meta
amaannawab923 Jun 3, 2025
d49ffb9
Supressing drag leaves columns hide
amaannawab923 Jun 4, 2025
14e3153
Time formatting
amaannawab923 Jun 4, 2025
cddc63c
Column config controls
amaannawab923 Jun 5, 2025
f114f2e
Handling long header titles
amaannawab923 Jun 5, 2025
2e1fba8
Column alignments
amaannawab923 Jun 5, 2025
e4a27ce
Long cell truncation as per superset table
amaannawab923 Jun 5, 2025
c0355d0
Min width
amaannawab923 Jun 5, 2025
d692718
Numeric alignment
amaannawab923 Jun 5, 2025
7d54a70
Removing unused var
amaannawab923 Jun 5, 2025
18ee5fc
Focus
amaannawab923 Jun 5, 2025
52379ce
Cell bar base implementation
amaannawab923 Jun 5, 2025
1a64961
Making formatter work with renderer
amaannawab923 Jun 5, 2025
f1f48b8
Control panel Update
amaannawab923 Jun 6, 2025
4934554
Show cell bars condition improvement
amaannawab923 Jun 6, 2025
1398a39
Time comparison Base Imp Completed
amaannawab923 Jun 11, 2025
66619e7
Style Update
amaannawab923 Jun 11, 2025
e21e6d3
Correct font
amaannawab923 Jun 11, 2025
45971cb
Icon update
amaannawab923 Jun 12, 2025
42021bb
Changing the name of ag grid table to table v2
amaannawab923 Jun 12, 2025
15c9d0a
Time comparison visibility controls
amaannawab923 Jun 12, 2025
230dc34
Filtering
amaannawab923 Jun 12, 2025
8b49437
Add colors to bars feedback point 1
amaannawab923 Jun 12, 2025
ca81dbe
Show totals
amaannawab923 Jun 12, 2025
0eaab7b
Feedback points completed
amaannawab923 Jun 12, 2025
430af27
Colors formatter correction
amaannawab923 Jun 12, 2025
32c1ea0
Fixing ts errors
amaannawab923 Jun 12, 2025
7d49dd2
Ci cd
amaannawab923 Jun 12, 2025
5ea2ea9
Time comparison feature flag
amaannawab923 Jun 12, 2025
ef84ad6
Col pinning fix
amaannawab923 Jun 12, 2025
c0b9170
Fixed pagination
amaannawab923 Jun 12, 2025
a75b3ac
Remove unused var
amaannawab923 Jun 12, 2025
a83b067
Fix
amaannawab923 Jun 12, 2025
04bffc9
Handling column menu for percent metric
amaannawab923 Jun 12, 2025
6473a70
Date comparator fix
amaannawab923 Jun 13, 2025
fd41211
Percent metric
amaannawab923 Jun 13, 2025
5f4987f
Correct field val
amaannawab923 Jun 13, 2025
a19c3c1
Allow rearrange control removed
amaannawab923 Jun 13, 2025
c698220
Moving ag grid table to experimental plugins
amaannawab923 Jun 13, 2025
9dc334b
Theme usage
amaannawab923 Jun 16, 2025
9730b48
font weight table cell
amaannawab923 Jun 16, 2025
999f24d
Refactor
amaannawab923 Jun 16, 2025
e767e10
Remove unused import
amaannawab923 Jun 16, 2025
a6a7ad3
Time comparison formatting
amaannawab923 Jun 17, 2025
e7e2a2e
Removing unuused var
amaannawab923 Jun 17, 2025
9b1de70
Using row index
amaannawab923 Jun 17, 2025
d800afc
Time comparison icons
amaannawab923 Jun 17, 2025
f7d9991
Visibility control
amaannawab923 Jun 17, 2025
fb01772
Header label correction
amaannawab923 Jun 17, 2025
c5e49af
Header label edge cases
amaannawab923 Jun 17, 2025
f61de42
Enabling feature flag
amaannawab923 Jun 17, 2025
f750d67
Fix
amaannawab923 Jun 18, 2025
0088d90
Converge Modules Phase 1
amaannawab923 Jun 23, 2025
00ab1fd
Merge master & fix conflicts
amaannawab923 Jun 23, 2025
1f31bf9
Fixing theme obj with resp to new theme
amaannawab923 Jun 23, 2025
b0a8537
Ci cd fix
amaannawab923 Jun 23, 2025
3ecd06f
Frontend Lint fix
amaannawab923 Jun 23, 2025
b309f25
Fixing pagination with theme
amaannawab923 Jun 23, 2025
5286ceb
Feat/converge modules phase 2
amaannawab923 Jun 24, 2025
3153be6
Update package & package lock
amaannawab923 Jun 24, 2025
14a7d27
Conflict package lock
amaannawab923 Jun 24, 2025
80794af
Revert "Conflict package lock"
amaannawab923 Jun 24, 2025
afbbb4f
Merge branch 'master' of https://github.com/apache/superset into feat…
amaannawab923 Jun 24, 2025
669588d
Updating Viz type key
amaannawab923 Jun 24, 2025
03717ed
Build issue
amaannawab923 Jun 24, 2025
3f336b8
ci cd fix
amaannawab923 Jun 24, 2025
36b88d2
Adding formdata
amaannawab923 Jun 24, 2025
4fe863d
Peer dependancy
amaannawab923 Jun 24, 2025
bd64729
Styling changes
amaannawab923 Jun 25, 2025
5b9f401
Filling grid width in case of column groups
amaannawab923 Jun 25, 2025
feb7b4c
Using bold for total
amaannawab923 Jun 25, 2025
4401957
Grid height correction
amaannawab923 Jun 25, 2025
0eaebd8
Auto height
amaannawab923 Jun 25, 2025
6660980
Refactored custom header
amaannawab923 Jun 25, 2025
4ecb747
Using theming api
amaannawab923 Jun 26, 2025
68b68e0
Dry code
amaannawab923 Jun 26, 2025
45f86c7
Removing popover
amaannawab923 Jun 26, 2025
efafd19
Using select from Superset ui / core
amaannawab923 Jun 26, 2025
22aac5a
Filter options fix for ant popover
amaannawab923 Jun 26, 2025
c076676
Filter options bug
amaannawab923 Jun 26, 2025
ac8df43
Theming changes
amaannawab923 Jun 27, 2025
48a7270
Theming changes
amaannawab923 Jun 27, 2025
5d772bb
Theming Changes (#20)
amaannawab923 Jul 3, 2025
5cc5e79
Theme consolidation into a single file (#21)
amaannawab923 Jul 3, 2025
a14e171
Feature flag
amaannawab923 Jul 3, 2025
a1d35a0
Using theme directly
amaannawab923 Jul 3, 2025
175eea2
Correct button group import
amaannawab923 Jul 3, 2025
99d8c5a
Filter style fixes
amaannawab923 Jul 4, 2025
00b2587
Calculating position same as ag grid
amaannawab923 Jul 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct field val
  • Loading branch information
amaannawab923 committed Jun 13, 2025
commit 5f4987f67c8af40d1afcf39ff52886d9aaded1a5
Original file line number Diff line number Diff line change
@@ -211,7 +211,7 @@ export const transformData = (
headerName: headerLabel,
...(isPercentMetric && {
filterValueGetter: params => {
const raw = params.data['%sum__num'];
const raw = params.data[params.colDef.field as string];
const formatter = params.colDef.valueFormatter as Function;
if (!raw || !formatter) return null;
const formatted = formatter({