feat(viz-type): Ag grid table plugin Integration #33517
Open
+12,222
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
* Temp * Fixing drill by * Enterprise checkpoint * Update context instead of custom meta as per preset * Open source cross filter update * Revert 1 * Remove enterprise * Revert from ent * Package lock
* fix(logo): fix logo url typo (apache#33867) * chore(Icons): Add UsergroupAddOutlined icon (apache#33866) * fix(api): Added uuid as a valid search column (apache#33833) * fix(native filters): Make the Apply button available after click on Clear All (apache#33834) * build(deps): remove legacy browser polyfills (apache#33853) Signed-off-by: hainenber <[email protected]> * build(dev-deps): update `fetch-mock` to v11 (apache#33854) Signed-off-by: hainenber <[email protected]> * build(be/deps): replace `importlib_metadata` usage with native Python 3.10+ `importlib.metadata` (apache#33868) Signed-off-by: hainenber <[email protected]> * chore: Updates files related to 5.0.0 release (apache#33869) * chore(docs): bump references to docker image versions upon release of 5.0.0 (apache#33872) --------- Signed-off-by: hainenber <[email protected]> Co-authored-by: Levis Mbote <[email protected]> Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Vitor Avila <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Sam Firke <[email protected]>
amaannawab923
requested review from
villebro,
betodealmeida,
nytai,
mistercrunch,
craig-rueda and
dpgaspar
as code owners
github-actions
bot
added
api
This reverts commit 14a7d27.
github-actions
bot
removed
api
| @@ -27,6 +27,8 @@ | |||
| "@react-icons/all-files": "^4.1.0", | |||
| "@types/d3-array": "^2.9.0", | |||
| "@types/react-table": "^7.7.20", | |||
| "ag-grid-community": "^33.1.1", | |||
There was a problem hiding this comment.
should this be in peerDependencies? Also wondering if we need to rethink where the main deps should live and how the peerDeps should be set. I think what makes more sense is to add the main dep in @superset-ui/core and have the main package/app AND plugins set them as peerDep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
FEATURE_CHART_PLUGINS_EXPERIMENTAL=true
This pr integrates the whole ag grid table with parity to Superset Tables with all of its functionalities as listed below:
10 . Column Customisation - ( Column Alignment , Formatting , Currency Formatting)
Below is the current State of Ag Grid table with all of the features:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION