[Bug] ApplicationBackUpCleanTask Runtime Error #4253
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
error log: |
GOODBOY008
previously approved these changes
Jun 8, 2025
GOODBOY008
reviewed
Jun 8, 2025
| backUpService.lambdaQuery() | ||
| .select(FlinkApplicationBackup::getAppId) | ||
| .groupBy(FlinkApplicationBackup::getAppId) | ||
| .having("count(*) > " + maxBackupNum) |
There was a problem hiding this comment.
Suggested change
| .having("count(*) > " + maxBackupNum) | |
| .having("COUNT(*) > {0}", maxBackupNum) |
There was a problem hiding this comment.
@Gianzie Use params to pass value will be better.
There was a problem hiding this comment.
Yeah, you are right, this way of writing can prevent SQL injection, I have made the changes, thx!
|
Gianzie
added a commit
to Gianzie/streampark
that referenced
this pull request
Jun 9, 2025
* [Bug] ApplicationBackUpCleanTask Runtime Error * [Improve] Prevent SQL injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
In the current code, the table "t_flink_app_backup" will be cleaned at 01:00 everyday, and the sql is "SELECT id,app_id,sql_id,config_id,path,description,version,create_time FROM t_flink_app_backup GROUP BY app_id HAVING count(*) > 5"
But mysql8.0 sql_mode is "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION", so this clean task is always error.
So I think we can just get "FlinkApplicationBackup::getAppId" column.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts