Skip to content

Commit 9738a5d

Browse files
authored
[Bug] ApplicationBackUpCleanTask Runtime Error (#4253)
* [Bug] ApplicationBackUpCleanTask Runtime Error * [Improve] Prevent SQL injection
1 parent ee96640 commit 9738a5d

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/ApplicationBackUpCleanTask.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,21 @@ public class ApplicationBackUpCleanTask {
4040
public void backUpClean() {
4141
log.info("Start to clean application backup");
4242
// select all application backup which count > maxBackupNum group by app_id
43-
backUpService.lambdaQuery().groupBy(FlinkApplicationBackup::getAppId)
44-
.having("count(*) > " + maxBackupNum).list().stream()
43+
backUpService.lambdaQuery()
44+
.select(FlinkApplicationBackup::getAppId)
45+
.groupBy(FlinkApplicationBackup::getAppId)
46+
.having("COUNT(*) > {0}", maxBackupNum)
47+
.list()
48+
.stream()
4549
.map(FlinkApplicationBackup::getAppId)
4650
.forEach(
4751
appId -> {
4852
// order by create_time desc and skip first maxBackupNum records and delete
4953
// others
50-
backUpService.lambdaQuery().eq(FlinkApplicationBackup::getAppId, appId)
51-
.orderByDesc(FlinkApplicationBackup::getCreateTime).list()
54+
backUpService.lambdaQuery()
55+
.eq(FlinkApplicationBackup::getAppId, appId)
56+
.orderByDesc(FlinkApplicationBackup::getCreateTime)
57+
.list()
5258
.stream()
5359
.skip(maxBackupNum)
5460
.forEach(

0 commit comments

Comments
 (0)