Skip to content

FLUME-3341 Fix:Taildir source may cause file handle leak and data duplication #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: flume-1.8
Choose a base branch
from
Open

FLUME-3341 Fix:Taildir source may cause file handle leak and data duplication #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...ldir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,17 @@ public List<Long> updateTailFiles(boolean skipToEnd) throws IOException {
for (File f : taildir.getMatchingFiles()) {
long inode = getInode(f);
TailFile tf = tailFiles.get(inode);
if (tf == null || !tf.getPath().equals(f.getAbsolutePath())) {
if (tf == null) {
long startPos = skipToEnd ? f.length() : 0;
tf = openFile(f, headers, inode, startPos);
} else if (!tf.getPath().equals(f.getAbsolutePath())) {
if (tf.getRaf() != null) {
tf.close();
logger.info("Close file at " + tf.getPath() + ", it no longer exists.");
}
long endPos = f.length() < tf.getPos() ? 0 : tf.getPos();
long startPos = skipToEnd ? f.length() : endPos;
tf = openFile(f, headers, inode, startPos);
} else {
boolean updated = tf.getLastUpdated() < f.lastModified() || tf.getPos() != f.length();
if (updated) {
Expand Down