FLUME-3341 Fix:Taildir source may cause file handle leak and data duplication #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix:Taildir source may cause file handle leak and data duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is described in Flume-3342, renaming a file may cause data duplication. But moreover, if the original file was opened by flume before and not closed yet, flume reopens it while not freeing its original file handles. And then I delete the new file, but after the idle time, flume just closes the new file handle and forgets to close its original file handles, leading to a handle leak. It can be found by "lsof | grep "deleted".
This bug is triggered by using Log4j to roll log files. To avoid losing data when rolling, I use regex to include both current log file and old log files in the taildir path.