-
Notifications
You must be signed in to change notification settings - Fork 15.3k
feat(hitl): include task_instance detail in hitl detail response #53373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hitl): include task_instance detail in hitl detail response #53373
Conversation
cc @guan404ming |
Thanks! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Wei! Could you please run static checks, the datamodel changes needs to be cascaded to airflowctl :)
Sure, I was working on a follow-up PR! let me do it now |
cc77c6e
to
86843ad
Compare
Somehow my local cannot generate the spec for some time 🤔 , but finally got it resolved! |
86843ad
to
9db557b
Compare
9db557b
to
9a648f7
Compare
9a648f7
to
d79bbbf
Compare
green! let's merge it |
Why
Needed by HITL frontend #53035
What
Replace
ti_id
withtask_instance
in get hitl detail public api^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.