Skip to content

feat(hitl): include task_instance detail in hitl detail response #53373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Jul 15, 2025

Why

Needed by HITL frontend #53035

What

Replace ti_id with task_instance in get hitl detail public api


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W
Copy link
Member Author

Lee-W commented Jul 15, 2025

cc @guan404ming

@guan404ming
Copy link
Contributor

Thanks! LGTM.

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Wei! Could you please run static checks, the datamodel changes needs to be cascaded to airflowctl :)

@Lee-W
Copy link
Member Author

Lee-W commented Jul 15, 2025

Looks good, thanks Wei! Could you please run static checks, the datamodel changes needs to be cascaded to airflowctl :)

Sure, I was working on a follow-up PR! let me do it now

@Lee-W Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from cc77c6e to 86843ad Compare July 15, 2025 17:05
@Lee-W Lee-W requested a review from kaxil as a code owner July 15, 2025 17:05
@Lee-W
Copy link
Member Author

Lee-W commented Jul 15, 2025

Somehow my local cannot generate the spec for some time 🤔 , but finally got it resolved!

@Lee-W Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 86843ad to 9db557b Compare July 16, 2025 06:47
@Lee-W Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 9db557b to 9a648f7 Compare July 16, 2025 06:50
@Lee-W Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 9a648f7 to d79bbbf Compare July 16, 2025 09:05
@Lee-W
Copy link
Member Author

Lee-W commented Jul 16, 2025

green! let's merge it

@Lee-W Lee-W merged commit 7d00376 into apache:main Jul 16, 2025
102 checks passed
@Lee-W Lee-W deleted the add-task-instance-detail-to-hitl-detail-response branch July 16, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants