-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Fix no_status and duration for grid summaries #53087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no_status and duration for grid summaries #53087
Conversation
airflow-core/src/airflow/api_fastapi/core_api/services/ui/grid.py
Outdated
Show resolved
Hide resolved
4252a14
to
7811523
Compare
7811523
to
7dc5c9a
Compare
@pierrejeambrun we have verified and this indeed resolves both issues. Thanks for quick fix. |
cc: @dstandish would love your input on that just to be sure it's not going against the original intention (since a lot has changed recently) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I agree with Pierre that Daniel's input would be great.
Lets merge it, I can follow up in case there is anything to update. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 8b04c38 v3-0-test This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Manual cherry pick there: |
@pierrejeambrun For the dynamic DAG when the version changes while the DAG is in running state the new graph is being generated but the state Colour are not rendering as the api is failing During handling of the above exception, another exception occurred: Traceback (most recent call last): |
@mpunch1 Thanks for your message. Can you share a minimal reproducible example DAG and process. Also I don't think this is related to this PR, but more generally to the recent grid refactoring that took place. What version of airflow are you using? |
@pierrejeambrun I am using airflow:3.0.3rc5, so basically how it works is that the DAG is dynamically generated using a for loop over an airflow variable. This particular variable is set in the prior task with some default dummy value, so that the DAG can be parsed. Initially when the DAG is parsed the graph is generated with this dummy value. |
* Fix no_status and duration for grid summaries * Fix CI
I don't think this is related to this specific PR. Can you test on RC4 and the problem should be the same of even worse, I suggest we continue the discussion on the linked dedicated issue thanks. |
* Fix no_status and duration for grid summaries * Fix CI
closes: #53078
closes: #53074
Tested for task group, and mapped task and clearing task.