-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Fix: Grid and Graph Rendering Issues in Airflow 3.0 for Dynamic DAGs #53079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Applied changes based on the latest DAG version ID (in descending order) to ensure correct rendering of the grid and graph views.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Are these related? Maybe we can prevent duplicate work |
@bugraoz93 - Thanks for the comment. I’ll review the PR, pull the changes, and check if the issue I raised has been resolved. |
@bugraoz93 - Thank you for resolving the grid issue - I have reviewed the latest main branch as well as your PR, and things are looking good on that front. I also tested the 3.0.3rc5 pre-release for my dynamic DAG use case. While the grid view now renders properly, I’m still noticing issues with task instance colors in the graph view - they don’t reflect the expected states. I would be happy to test a newer pre-release once those fixes are in, especially to verify whether the grid and graph color rendering are fully resolved. If helpful, I’m available for a quick 1:1 call to walk you through the issue (though I won’t be able to share actual code due to organizational confidentiality policies). :) Thanks again for the prompt fix and ongoing support ! |
@bugraoz93 One of the issue is related to that, but for the dynamic DAG when the version changes while the DAG is in running state the new graph is being generated but the state Colour are not rendering as the api is failing |
@mpunch1 @arunangshu01 can you double check on latest RC (rc5), also can you provide a minimal dummy DAG that reproduces the problem? |
@bugraoz93, @pierrejeambrun - Here you go with a sample dag code. |
I just followed up. Thanks to Pierre! :) Also, thanks for your PR!
Thanks for example! |
Is this DAG failing? |
yes the DAG either fails(even after the retries) or it get parsed before reaching the task and the new DAG is graph is rendered but the task state colors are not reflected because the api fails. Thanks @bugraoz93 |
Thanks that would be amazing @mpunch1! |
Thanks @arunangshu01 for the reproducible example. cc: @dstandish This might be related to the recent grid optimization / refactoring. |
Let us know your findings, thanks |
Related Issues -
This PR addresses a consistent issue observed during recent tests involving dynamic DAGs in Airflow 3.0. Specifically, when a variable is updated within an ongoing task, the DAG version used for rendering the graph view incorrectly falls back to the initial DAG version instead of the latest one.
As a result, the graph colors are not properly rendered, making it difficult to trace the current state and flow across different stages of the DAG run. This fix ensures that both the grid and graph views correctly reference the latest DAG version (in descending order), improving visibility and debugging during pipeline execution.
Contributors are welcome to review, test, and suggest improvements.
Thank you!