Adjustment external views #51889
Merged
Adjustment external views #51889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ryanahamilton,
jscheffl,
shubhamraj-git,
bugraoz93,
kaxil,
potiuk,
ephraimbuddy,
rawwar and
jason810496
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:API
|
Second commit looks weird, (pre-commit hook formatting for generated files). Fixed in: #51890 |
pierrejeambrun
force-pushed
the
51855-update-iframe-views
branch
2 times, most recently
from
4c79e8e to
74dfc89
Compare
hussein-awala
approved these changes
Jun 18, 2025
bugraoz93
approved these changes
Jun 18, 2025
bbovenzi
reviewed
Jun 18, 2025
bbovenzi
reviewed
Jun 18, 2025
pierrejeambrun
force-pushed
the
51855-update-iframe-views
branch
from
74dfc89 to
06d88e6
Compare
|
Still work needed to refine and handle the dark mode icon, icons for sub menus of app builder items, fix some styling, small refactoring and component extraction. (this wasn't introduced in this PR, I did my best to fix the smalls things that were straigh forward, but it needs more love, I will do that in a followup) Single app builder menu item
Multiple app builder menu items
Single external_view
Mixed
|
jscheffl
reviewed
Jun 21, 2025
airflow-core/src/airflow/api_fastapi/core_api/datamodels/plugins.py
Outdated
Show resolved
Hide resolved
|
Thanks for the review Jens! (1) Yes I also noticed that, I figured we will fix it in a followup PR because I don't have a straight forward for it and it was already existing prior to this PR. |
bbovenzi
approved these changes
Jun 23, 2025
pierrejeambrun
force-pushed
the
51855-update-iframe-views
branch
from
6a5dec3 to
a2bbc15
Compare
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #51855