Skip to content

Commit 6a5dec3

Browse files
Small update
1 parent 62b0b69 commit 6a5dec3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

airflow-core/docs/administration-and-deployment/plugins.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ definitions in Airflow.
201201
# the context variables available will be different, i.e a subset of (DAG_ID, RUN_ID, TASK_ID, MAP_INDEX).
202202
"href": "https://example.com/{DAG_ID}/{RUN_ID}/{TASK_ID}",
203203
# Destination of the iframe view. This is used to determine where the iframe will be loaded in the UI.
204-
# Supported locations are Literal["nav", "dag", "dag_run", "task", "task_instance"]
204+
# Supported locations are Literal["nav", "dag", "dag_run", "task", "task_instance"], default to "nav".
205205
"destination": "dag_run",
206206
# Optional icon, url to an svg file.
207207
"icon": "https://example.com/icon.svg",

airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenuItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export const PluginMenuItem = ({ href, icon, name, topLevel = false, url_route:
4545
/>
4646
) : (
4747
<Box alignItems="center" display="flex" gap={2} outline="none" px={2}>
48-
<Link aria-label={name} href={href} px={2} rel="noopener noreferrer" target="_blank" width="100%">
48+
<Link aria-label={name} href={href} rel="noopener noreferrer" target="_blank" width="100%">
4949
{name}
5050
</Link>
5151
</Box>

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_plugins.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def test_external_views_model_validator(self, test_client):
8989
{
9090
"category": "Search",
9191
"dark_mode_icon": None,
92-
"destination": None,
92+
"destination": "nav",
9393
"href": "https://www.google.com",
9494
"icon": None,
9595
"name": "Google",
@@ -98,7 +98,7 @@ def test_external_views_model_validator(self, test_client):
9898
{
9999
"category": None,
100100
"dark_mode_icon": None,
101-
"destination": None,
101+
"destination": "nav",
102102
"href": "https://www.apache.org/",
103103
"icon": None,
104104
"label": "The Apache Software Foundation",

0 commit comments

Comments
 (0)