Skip to content

Move Dag, run and TI into common.json #51622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 11, 2025

Clean up redundancies in our translation files:

  • Have all the translations for each field on a Dag, Dag Run, and TaskInstance in one place
  • Move a few shared fields (endDate, duration, dagId, runId, etc) into the top level common.json

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also makes very much sense to me! Go for it!

@bbovenzi bbovenzi marked this pull request as ready for review June 11, 2025 20:40
@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone Jun 11, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me realize how incomplete some translations are. I really hope people take a look at this in advance of 3.1.0

@bbovenzi
Copy link
Contributor Author

@pierrejeambrun Yeah, if we don't see progress on a language at least 2 weeks before we plan to release 3.1.0 then I think we should comment it out. I only want to release languages with full support

@bbovenzi bbovenzi merged commit 5a3257f into apache:main Jun 12, 2025
42 checks passed
@bbovenzi bbovenzi deleted the rearrange-translation-files branch June 12, 2025 13:33
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Jun 14, 2025
* Move Dag, run and TI into common.json

* Update more translation refs

* Consolidate a few more fields, fix german keys

* Extra consolidation plus refactor keys for all other languages

* Fix config
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Jun 14, 2025
* Move Dag, run and TI into common.json

* Update more translation refs

* Consolidate a few more fields, fix german keys

* Extra consolidation plus refactor keys for all other languages

* Fix config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants