Skip to content

Migrate remaining plaintext to translation files #51635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 11, 2025

Move all of the remaining plaintext to translation files and upgrade our eslint rule for plaintext in jsx from WARN to ERROR

Closes #50861


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@bbovenzi bbovenzi force-pushed the run-and-task-translate branch from 8d5ef34 to 6a06401 Compare June 12, 2025 13:42
@bbovenzi bbovenzi marked this pull request as ready for review June 12, 2025 13:47
@bbovenzi bbovenzi changed the title Migrate Run, Task and TI plaintext to translation files Migrate remaining plaintext to translation files Jun 12, 2025
@bbovenzi bbovenzi requested a review from Lee-W as a code owner June 12, 2025 15:30
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a milestone 🎉

Code looks good, as long as the CI is happy, we should be good :)

Fix tryNumber key

Fix run details merge issues

Replace all plaintext and change eslint to ERROR

Fix zh-tw assets file
@bbovenzi bbovenzi force-pushed the run-and-task-translate branch from e913836 to c0e3706 Compare June 12, 2025 15:43
@bbovenzi bbovenzi merged commit ab3f0ec into apache:main Jun 12, 2025
43 checks passed
@bbovenzi bbovenzi deleted the run-and-task-translate branch June 12, 2025 16:41
@jscheffl
Copy link
Contributor

Oh, now translation is completed! VERY COOL!

choo121600 pushed a commit to choo121600/airflow that referenced this pull request Jun 14, 2025
Fix tryNumber key

Fix run details merge issues

Replace all plaintext and change eslint to ERROR

Fix zh-tw assets file
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Jun 14, 2025
Fix tryNumber key

Fix run details merge issues

Replace all plaintext and change eslint to ERROR

Fix zh-tw assets file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n - Replace all plaintext with english translation files
3 participants