-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Improve xcom_pull
to cover different scenarios for mapped tasks
#51568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amoghrajesh
merged 9 commits into
apache:main
from
astronomer:pull-xcom-mapped-task-from-jinja
Jun 12, 2025
Merged
Improve xcom_pull
to cover different scenarios for mapped tasks
#51568
amoghrajesh
merged 9 commits into
apache:main
from
astronomer:pull-xcom-mapped-task-from-jinja
Jun 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcom_pull
to reflect reality for mapped tasksxcom_pull
to cover different scenarios for mapped tasks
uranusjr
reviewed
Jun 11, 2025
uranusjr
reviewed
Jun 11, 2025
uranusjr
reviewed
Jun 11, 2025
uranusjr
approved these changes
Jun 11, 2025
Co-authored-by: Tzu-ping Chung <[email protected]>
Thanks for the review, merging it. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #50686
Problem
The expected behaviour from a downstream task pulling xcoms off of a mapped task would be to pull ALL the xcoms for that mapped task (all map indexes). Right now the problem we are suffering from is the way we treat defaults in our current logic.
Our logic is broken in a way that if map indexes arent specified, we function in a way that we pull from the corresponding map index of upstream task. This is because of the way we handle defaults as of now:
https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/execution_time/task_runner.py#L349-L360
Scenarios that show how things work:
This is wrong. We should be pulling from all map indexes of the upstream task if not specified.
Approach
Leveraging: #50117 here. If you pass in the
start
,end
,step
as None -- the API is designed to return ALL the xcoms for the task, exactly what we want.So i am currently changing the logic to "if map_indexes aren't provided, fetch all the map_indexes available".
Testing
Test 1: Checking with DAG provided by @TJaniF
DAG:
Test 2: DAG reported by issue reporter
DAG:
Test 3: Created a comprehensive DAG to cover all use cases
This dag handles all possible scenarios:
Logs:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.