Fix first time contributor detection with time constraints #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to fix an issue where seasoned developers are getting the first PR welcome messages from boring cyborg. Example:
apache/airflow#51568: new merge message
apache/airflow#51639: first PR message
The issue seems to be that prior to bf2ed3f#diff-2246d6bc20982f5f3edcd6f28b634c1af98104bd5700c154abc00209f9e1f454, github api was used to detect
the first contributor's, but its replaced with octokit now.
The GitHub Search API has a default ordering behaviour where
But octokit doesn't do that. So, using an explicit temporal constraint guarantees we only look at PRs that existed before the current one and it is a more fool-proof way too.