-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Translate all components #51243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate all components #51243
Conversation
867f9e2
to
1704719
Compare
1704719
to
6662364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to wait - the script for now is just flagging the differences but it's not (and should not be) run as pre-commit - because we need to sort out the process of updating the translation. I can't imagine the one who adds a new string is also adding translations for all the unfamiliar languages. That is one of the challenges of the i18n that we need to solve that whatever change in structure or new string we add, we should also figure out how we are doing it for all translations - @jscheffl implemented it all for German and English, but now other languages will need to catch up and we need to figure out how to make it happen. that's why the script is for now just runnable - but it's not run as pre-commit and individual authors might run it to fix things for example: #51271 But there is no "hard" dependency between these. |
Agree. I just added the new German stuff to check the translation outcome. And there are other German gaps also but I'd add them in a different PR. |
6662364
to
647c003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions on the German parts :)
Thanks for the review. Amoungst too many changes it seems I need to get a new keyboard where the letter "e" is typed when I press - it seems in a couple of cases the "e" was just missed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the PR.
I feel like it remains plenty of other places untranslated, still with the english fallback. A couple of example in the drop down bellow. Also you can run eslint to see where we are still using string literal:
yarn lint
Carefull, dynamic labels and stuff coming from js variable do not seem do be detected. So there might be more to fix.
I think this is a mis-understanding :-D I was not intending to translate ALL leftovers in the UI (and there are plenty left!) but attempted to translate all "UI components" (modular things that are in the "components" subfolder. That also means there are not all parts of the UI, especially "pages" translated. Also some TS files have terms as enums and lists which need some separate efforts. |
8f84c5a
to
48ffd65
Compare
Ah got it! Thanks |
* Translate all components * Further component translation * Fix test * Fix re-sorting after rebase * Fix useLogs after review
Translate all components in the UI
Uff... sorry this is a large one :-(
related: #50861