Skip to content

Translate all components #51243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2025

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented May 30, 2025

Translate all components in the UI

Uff... sorry this is a large one :-(

related: #50861

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 30, 2025
@jscheffl jscheffl force-pushed the feature/translate-all-ui-components branch from 867f9e2 to 1704719 Compare May 30, 2025 21:53
@jscheffl jscheffl marked this pull request as ready for review May 30, 2025 21:53
@jscheffl jscheffl force-pushed the feature/translate-all-ui-components branch from 1704719 to 6662364 Compare May 31, 2025 12:08
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Before merging, we probably want to merge #51269 first to avoid inconsistencies between existing translations. Also, I think it's worth thinking of a policy of how we manage changes regarding language files. I'll raise a discussion about it in the dev list.

cc: @potiuk

@potiuk
Copy link
Member

potiuk commented Jun 1, 2025

Before merging, we probably want to merge #51269 first to avoid inconsistencies between existing translations. Also, I think it's worth thinking of a policy of how we manage changes regarding language files. I'll raise a discussion about it in the dev

No need to wait - the script for now is just flagging the differences but it's not (and should not be) run as pre-commit - because we need to sort out the process of updating the translation. I can't imagine the one who adds a new string is also adding translations for all the unfamiliar languages. That is one of the challenges of the i18n that we need to solve that whatever change in structure or new string we add, we should also figure out how we are doing it for all translations - @jscheffl implemented it all for German and English, but now other languages will need to catch up and we need to figure out how to make it happen.

that's why the script is for now just runnable - but it's not run as pre-commit and individual authors might run it to fix things for example: #51271

But there is no "hard" dependency between these.

@jscheffl
Copy link
Contributor Author

jscheffl commented Jun 1, 2025

the script for now is just flagging the differences but it's not (and should not be) run as pre-commit - because we need to sort out the process of updating the translation. I can't imagine the one who adds a new string is also adding translations for all the unfamiliar languages. That is one of the challenges of the i18n that we need to solve that whatever change in structure or new string we add, we should also figure out how we are doing it for all translations - @jscheffl implemented it all for German and English, but now other languages will need to catch up and we need to figure out how to make it happen.

that's why the script is for now just runnable - but it's not run as pre-commit and individual authors might run it to fix things for example: #51271

But there is no "hard" depende

Agree. I just added the new German stuff to check the translation outcome. And there are other German gaps also but I'd add them in a different PR.

@jscheffl jscheffl force-pushed the feature/translate-all-ui-components branch from 6662364 to 647c003 Compare June 1, 2025 17:26
Copy link
Contributor

@TJaniF TJaniF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions on the German parts :)

@jscheffl
Copy link
Contributor Author

jscheffl commented Jun 2, 2025

Few suggestions on the German parts :)

Thanks for the review. Amoungst too many changes it seems I need to get a new keyboard where the letter "e" is typed when I press - it seems in a couple of cases the "e" was just missed...

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR.

I feel like it remains plenty of other places untranslated, still with the english fallback. A couple of example in the drop down bellow. Also you can run eslint to see where we are still using string literal:

yarn lint

Carefull, dynamic labels and stuff coming from js variable do not seem do be detected. So there might be more to fix.

More than a 100 occurences still remain like this:
Screenshot 2025-06-04 at 17 12 30

Screenshot 2025-06-04 at 17 08 30

Screenshot 2025-06-04 at 17 10 58

@jscheffl
Copy link
Contributor Author

jscheffl commented Jun 4, 2025

Nice, thanks for the PR.

I feel like it remains plenty of other places untranslated, still with the english fallback. A couple of example in the drop down bellow. Also you can run eslint to see where we are still using string literal:

I think this is a mis-understanding :-D I was not intending to translate ALL leftovers in the UI (and there are plenty left!) but attempted to translate all "UI components" (modular things that are in the "components" subfolder.
I am sure there is plenty room for next PRs but all at the same time would be crazy complex. (=merge conflict generator)

That also means there are not all parts of the UI, especially "pages" translated. Also some TS files have terms as enums and lists which need some separate efforts.

@jscheffl jscheffl force-pushed the feature/translate-all-ui-components branch from 8f84c5a to 48ffd65 Compare June 4, 2025 20:44
@jscheffl jscheffl merged commit 5682730 into apache:main Jun 4, 2025
43 checks passed
@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone Jun 4, 2025
@pierrejeambrun
Copy link
Member

Ah got it! Thanks

sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Translate all components

* Further component translation

* Fix test

* Fix re-sorting after rebase

* Fix useLogs after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants